Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert the _sourceHost changes #535

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Revert the _sourceHost changes #535

merged 1 commit into from
Mar 30, 2020

Conversation

perk-sumo
Copy link
Contributor

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@perk-sumo
Copy link
Contributor Author

@pmaciolek please let me know if we should revert anything more, eg. this line:
https://github.com/SumoLogic/sumologic-kubernetes-collection/compare/b0a5e1b60f14cd9d442c0293add5d316beb633c0..revert-the-source-host-changes#diff-674608f7da553d4906800c0944c94ff1R24

sumo-drosiek
sumo-drosiek approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pmm-sumo
pmm-sumo suggested changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@pmm-sumo pmm-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change does following;

  • fixes passing SOURCE_HOST env variable
  • sets _sourceHost to default value consistent with what was used elsewhere

We must not revert the first item. We can the second

@pmm-sumo
Copy link
Contributor

After discussion - since this was not exposed in values.yaml we should be good with reverting the change fully

@perk-sumo perk-sumo merged commit 3905b8d into release-v0.17 Mar 30, 2020
@perk-sumo perk-sumo deleted the revert-the-source-host-changes branch March 30, 2020 16:59
@perk-sumo perk-sumo mentioned this pull request Mar 31, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@pmm-sumo pmm-sumo pmm-sumo approved these changes

@samjsong samjsong Awaiting requested review from samjsong

@vsinghal13 vsinghal13 Awaiting requested review from vsinghal13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@perk-sumo @pmm-sumo @sumo-drosiek