Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hostname and _sourceHost fix for v0.17 #530

Merged
merged 5 commits into from
Mar 26, 2020
Merged

Hostname and _sourceHost fix for v0.17 #530

merged 5 commits into from
Mar 26, 2020

Conversation

pmm-sumo
Copy link
Contributor

Description

This does several things:

  • uses host rather than hostName for the tag
  • bumps OpenTelemetry Collector to more recent version (with config format changed)
  • add default value to _sourceHost (being the... host)
  • removes start_time tag
Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@pmm-sumo pmm-sumo changed the title [WIP] Hostname and _sourceHost fix for v0.17 Hostname and _sourceHost fix for v0.17 Mar 26, 2020
samjsong
samjsong approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sumo-drosiek
sumo-drosiek approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

perk-sumo
perk-sumo approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@perk-sumo perk-sumo force-pushed the hostname-fix-v0.17 branch from 31cde17 to 76dbfaf Compare March 26, 2020 17:45
@perk-sumo perk-sumo changed the base branch from release-v0.17-backports to release-v0.17 March 26, 2020 17:45
@perk-sumo perk-sumo merged commit 76dbfaf into release-v0.17 Mar 26, 2020
@perk-sumo perk-sumo deleted the hostname-fix-v0.17 branch March 26, 2020 17:47
@pmm-sumo pmm-sumo mentioned this pull request Mar 27, 2020
Closed
3 tasks
@perk-sumo
Copy link
Contributor

Hostname and _sourceHost changes reverted in #535

@pmm-sumo pmm-sumo mentioned this pull request Apr 6, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perk-sumo perk-sumo perk-sumo approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@samjsong samjsong samjsong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pmm-sumo @perk-sumo @samjsong @sumo-drosiek @pmaciolek