Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OtelCol and clean up tags #560

Merged
merged 2 commits into from
Apr 6, 2020
Merged

Update OtelCol and clean up tags #560

merged 2 commits into from
Apr 6, 2020

Conversation

pmm-sumo
Copy link
Contributor

@pmm-sumo pmm-sumo commented Apr 6, 2020

Description

This is a replacement for https://github.com/SumoLogic/sumologic-kubernetes-collection/pull/521/files

  • uses host rather than hostName for the tag
  • bumps OpenTelemetry Collector to more recent version (with config format changed)
  • removes start_time tag

This is v1.0 equivalent of #530

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@pmm-sumo pmm-sumo mentioned this pull request Apr 6, 2020
Closed
3 tasks
@pmm-sumo pmm-sumo requested a review from sumo-drosiek April 6, 2020 09:33
sumo-drosiek
sumo-drosiek approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do want to backport those changes to 0.17?
In case of update from 0.17 those values are going to be overrided by current customer configuration

@pmm-sumo pmm-sumo mentioned this pull request Apr 6, 2020
Merged
3 tasks
perk-sumo
perk-sumo approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@perk-sumo perk-sumo merged commit 7a9f085 into master Apr 6, 2020
@perk-sumo perk-sumo deleted the otelcol-update branch April 6, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perk-sumo perk-sumo perk-sumo approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmm-sumo @sumo-drosiek @perk-sumo @pmaciolek