This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
feat(Network): Adds retry mechanism for the failed networking requests #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
me2k
suggested changes
Mar 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of strong retaining blocks in here, take a look and see what you think?
AFNetworkDataSource.swift
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this deleted? It is referenced in the DI/NetworkModule.swift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not this one, it seems this file is duplicated in the repo
Co-authored-by: Myles Eynon <me2k@users.noreply.github.com>
me2k
approved these changes
Mar 22, 2023
thomas-james-1986
approved these changes
Mar 22, 2023
sa-release-bot-public-repo bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
# [8.6.0](v8.5.7...v8.6.0) (2023-04-19) ### Bug Fixes * **Bumper:** calling dismiss on the presenting viewcontroller if one exists and cleaning up the timer ([#292](#292)) ([a88f15c](a88f15c)) * **CI:** Locked in Circle CI macos.x86.medium.gen2 resource class ([#279](#279)) ([8e18233](8e18233)) * **Interactive Video:** Added Video Leave Warning dialog and close at end option to IV. ([#280](#280)) ([a7d38a8](a7d38a8)) * **InteractiveVideo:** Added Player end and pause events and play and resume methods to the Managed Ad View ([#290](#290)) ([9f53899](9f53899)) * **Settings:** Added a settings screen to the test app for testing. ([#284](#284)) ([5dcd9ce](5dcd9ce)) * **Test Ads:** Made the duration parameter optional in the Decodable object ([#283](#283)) ([2fbf955](2fbf955)) ### Features * **Network:** Adds retry mechanism for the failed networking requests ([#278](#278)) ([a7a43d6](a7a43d6))
🎉 This PR is included in version 8.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
AAG-2853
DESCRIPTION
Adds retry mechanism for the failed networking requests
SCREENSHOTS
n/a