Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

feat(Network): Adds retry mechanism for the failed networking requests #278

Merged
merged 5 commits into from
Mar 27, 2023

Conversation

gunhansancar
Copy link
Contributor

@gunhansancar gunhansancar commented Mar 22, 2023

JIRA

AAG-2853

DESCRIPTION

Adds retry mechanism for the failed networking requests

SCREENSHOTS

n/a

@gunhansancar gunhansancar requested review from a team and Banford March 22, 2023 10:56
@gunhansancar gunhansancar self-assigned this Mar 22, 2023
Copy link
Contributor

@me2k me2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of strong retaining blocks in here, take a look and see what you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this deleted? It is referenced in the DI/NetworkModule.swift

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not this one, it seems this file is duplicated in the repo

Gunhan Sancar and others added 2 commits March 22, 2023 14:25
Co-authored-by: Myles Eynon <me2k@users.noreply.github.com>
@gunhansancar gunhansancar requested a review from me2k March 22, 2023 14:30
@gunhansancar gunhansancar merged commit a7a43d6 into develop Mar 27, 2023
@gunhansancar gunhansancar deleted the feat/AAG-2853-add-retry-mechanism branch March 27, 2023 09:13
sa-release-bot-public-repo bot pushed a commit that referenced this pull request Apr 19, 2023
# [8.6.0](v8.5.7...v8.6.0) (2023-04-19)

### Bug Fixes

* **Bumper:** calling dismiss on the presenting viewcontroller if one exists and cleaning up the timer ([#292](#292)) ([a88f15c](a88f15c))
* **CI:** Locked in Circle CI macos.x86.medium.gen2 resource class ([#279](#279)) ([8e18233](8e18233))
* **Interactive Video:** Added Video Leave Warning dialog and close at end option to IV. ([#280](#280)) ([a7d38a8](a7d38a8))
* **InteractiveVideo:** Added Player end and pause events and play and resume methods to the Managed Ad View ([#290](#290)) ([9f53899](9f53899))
* **Settings:** Added a settings screen to the test app for testing. ([#284](#284)) ([5dcd9ce](5dcd9ce))
* **Test Ads:** Made the duration parameter optional in the Decodable object ([#283](#283)) ([2fbf955](2fbf955))

### Features

* **Network:** Adds retry mechanism for the failed networking requests ([#278](#278)) ([a7a43d6](a7a43d6))
@sa-release-bot-public-repo
Copy link

🎉 This PR is included in version 8.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants