This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
fix(InteractiveVideo): Added Player end and pause events and play and resume methods to the Managed Ad View #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… resume methods to the Managed Ad View
me2k
commented
Apr 5, 2023
Comment on lines
+65
to
+67
| adPaused: function() { postMessageToBridge("\(AdEvent.adPaused.rawValue)"); }, | ||
| adPlaying: function() { postMessageToBridge("\(AdEvent.adPlaying.rawValue)"); } | ||
| }; |
There was a problem hiding this comment.
Added adPlaying and adPaused events for the WebSDK to communicate back up
me2k
commented
Apr 5, 2023
Comment on lines
+111
to
+120
| func adPaused() { | ||
| callback?(placementId, .adPaused) | ||
| logger.info("Event callback: adPaused for placement \(placementId)") | ||
| } | ||
|
|
||
| func adPlaying() { | ||
| callback?(placementId, .adPlaying) | ||
| logger.info("Event callback: adPlaying for placement \(placementId)") | ||
| } | ||
|
|
There was a problem hiding this comment.
Exposed hooks in the Native SDK for adPlaying and adPaused
me2k
commented
Apr 5, 2023
Comment on lines
+196
to
+197
| case adPaused = 9 | ||
| case adPlaying = 10 |
There was a problem hiding this comment.
Added cases for adPlaying and adPaused these are not breaking changes.
me2k
commented
Apr 5, 2023
Comment on lines
114
to
120
| func playVideo() { | ||
| webView.evaluateJavaScript("playVideo();") | ||
| } | ||
|
|
||
| func pauseVideo() { | ||
| webView.evaluateJavaScript("pauseVideo();") | ||
| } |
There was a problem hiding this comment.
The two new methods for playing and pausing a video, these are the subject of our discussions at the moment.
sa-release-bot-public-repo bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
# [8.6.0](v8.5.7...v8.6.0) (2023-04-19) ### Bug Fixes * **Bumper:** calling dismiss on the presenting viewcontroller if one exists and cleaning up the timer ([#292](#292)) ([a88f15c](a88f15c)) * **CI:** Locked in Circle CI macos.x86.medium.gen2 resource class ([#279](#279)) ([8e18233](8e18233)) * **Interactive Video:** Added Video Leave Warning dialog and close at end option to IV. ([#280](#280)) ([a7d38a8](a7d38a8)) * **InteractiveVideo:** Added Player end and pause events and play and resume methods to the Managed Ad View ([#290](#290)) ([9f53899](9f53899)) * **Settings:** Added a settings screen to the test app for testing. ([#284](#284)) ([5dcd9ce](5dcd9ce)) * **Test Ads:** Made the duration parameter optional in the Decodable object ([#283](#283)) ([2fbf955](2fbf955)) ### Features * **Network:** Adds retry mechanism for the failed networking requests ([#278](#278)) ([a7a43d6](a7a43d6))
|
🎉 This PR is included in version 8.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
AAG-3024
DESCRIPTION
Added Player end and pause events and play and resume methods to the Managed Ad View, this also includes a refactor for the Javascript message handlers.
NOTE: the play / pause javascript functions are not final as we are still discussing how to control this with the AA Mid team.
SCREENSHOTS
n/a