Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider replacing JSON Schema validation library #20

Open
ianshade opened this issue Sep 3, 2023 · 3 comments
Open

Consider replacing JSON Schema validation library #20

ianshade opened this issue Sep 3, 2023 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@ianshade
Copy link
Member

ianshade commented Sep 3, 2023

In certain scenarios the validator from the jsonschema package doesn't work in the browser out of the box, without additionally installing a polyfill (tdegrunt/jsonschema#367), because it only supports Node.js (tdegrunt/jsonschema#383 (comment)). This is an issue that I encountered in a project using Vite.
It also appears this library is the slowest one available - see https://github.com/ebdrup/json-schema-benchmark.
Without doing much research, my initial recommendation would be to switch to https://github.com/ajv-validator/ajv.
@nytamin
Copy link
Member

nytamin commented Sep 4, 2023

Sounds good to me! I'm all for it! :)

@nytamin nytamin added the help wanted Extra attention is needed label Sep 4, 2023
@henryrgithub henryrgithub mentioned this issue Apr 4, 2024
Merged
@tdegrunt
Copy link

tdegrunt commented Apr 5, 2024

The above PR should address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tdegrunt @ianshade @nytamin and others