Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use web URL API instead of Node URL library #396

Merged
merged 11 commits into from
Apr 5, 2024

Conversation

henryrgithub
Copy link
Contributor

Addresses #395, #393, #367, and #20. Motivated generally by wanting to frictionlessly use jsonschema while prototyping with Vite.

2764 tests passed, 9 pending, same as before changes.

I am looking at making a resolve helper method instead of duplicating logic everywhere, but I need to educate myself on JS scoping stuff before making it work.

I also changed the test suite submodule URL to https from git, I think submodule init for it will work whether or not you SSH'd or HTTPS'd the repo. I'll happily revert if that's more appropriate for a seperate PR or git syntax is preffered.

@henryrgithub
Copy link
Contributor Author

Refactored to use a helper function instead of duplicated code.

@tdegrunt tdegrunt merged commit 0742229 into tdegrunt:master Apr 5, 2024
@tdegrunt
Copy link
Owner

tdegrunt commented Apr 5, 2024

Nice, that solves quite a few problems in one go!
Thank you!

@Sinled
Copy link

Sinled commented May 6, 2024

Was this fix released? It seems no newer versions on npm.

@wubaibai
Copy link

Hi, @tdegrunt, May I know when will this fix to be released to npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants