Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing dependency for url #383

Closed
wants to merge 1 commit into from
Closed

fix missing dependency for url #383

wants to merge 1 commit into from

Conversation

smeng9
Copy link

@smeng9 smeng9 commented Mar 30, 2023

Closes #367

@tdegrunt can you help take a look and release a new version?

@smeng9
Copy link
Author

smeng9 commented Apr 19, 2023

Hi @tdegrunt any updates on this? We will need the url dependency in order to properly use this package.

@awwright
Copy link
Collaborator

awwright commented May 9, 2023

@smeng9 The "url" package should be builtin. Can you tell me a little more about your environment?

@smeng9
Copy link
Author

smeng9 commented May 14, 2023

Hi @awwright,

I am using yarn pnp as package manager with vite to build my projects. It gives the following error Module “url” has been externalized for browser compatibility.

Someone else also posted on the original issue on how to reproduce this problem. #367 (comment)

@smeng9
Copy link
Author

smeng9 commented May 25, 2023

Hi @awwright, Any updates on this? The url package is not built-in and we need to fix the dependencies in order to use it.

@awwright
Copy link
Collaborator

@smeng9 We only claim to support Node.js where url ought to be built-in; and any tools that adapt the code for other environments must support Node.js compatibility. You should file an issue upstream with your package manager, and link it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find module 'url'
2 participants