Implemented the PSP22 via pallet-assets chain extension.
#168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library provides default implementation that can be re-used. The change is not fully ready it requires more examples, tests, and documentation.
xgreenx
added a commit
to xgreenx/chainextension-registry
that referenced
this pull request
Aug 20, 2022
The id of the chain extension is `0x48f6`. It is the first 2 bytes of the `blake2b` hash from the "pallet-assets-chain-extension@v0.1" string. The [chain extension](https://github.com/Supercolony-net/pallet-assets-chain-extension) created with usage of the [`obce`](https://github.com/Supercolony-net/obce) crate. The chain extension is not ready for production because it requires some additional changes on the `pallet-assets` side(some operations should be performed by the contract only if the contract is admin). But it is a matter of time, so I think we can register it and fix it with minor patches. Added support of the extension into [substrate-contract-node](paritytech/substrate-contracts-node#146) and into [OpenBrush](Supercolony-net/openbrush-contracts#168).
|
HCastano
pushed a commit
to paritytech/chainextension-registry
that referenced
this pull request
Aug 22, 2022
* Add `pallet-assets` chain extension. The id of the chain extension is `0x48f6`. It is the first 2 bytes of the `blake2b` hash from the "pallet-assets-chain-extension@v0.1" string. The [chain extension](https://github.com/Supercolony-net/pallet-assets-chain-extension) created with usage of the [`obce`](https://github.com/Supercolony-net/obce) crate. The chain extension is not ready for production because it requires some additional changes on the `pallet-assets` side(some operations should be performed by the contract only if the contract is admin). But it is a matter of time, so I think we can register it and fix it with minor patches. Added support of the extension into [substrate-contract-node](paritytech/substrate-contracts-node#146) and into [OpenBrush](Supercolony-net/openbrush-contracts#168). * Update registry.json Co-authored-by: Alexander Theißen <alex.theissen@me.com> Co-authored-by: Alexander Theißen <alex.theissen@me.com>
o-tsaruk
approved these changes
Aug 23, 2022
xgreenx
commented
Aug 25, 2022
| // | ||
| // describe('MY_PSP22', () => { | ||
| // async function setup() { | ||
| // return setupContract('my_psp22_pallet', 'new', 123, '0', '1000') |
There was a problem hiding this comment.
To deploy a contract on the local node(from paritytech/substrate-contracts-node#146) you need to pass 10000 Units in the constructor. It is required deposit to create and Asset
There was a problem hiding this comment.
It works with polkadot js and don't work with redspot in integration tests. I'll try to use polkadot js directly
xgreenx
commented
Aug 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the
PSP22viapallet-assetschain extension. AlsoMetadata,Mintable, andBurnable.The library provides a default implementation that can be re-used.
Replaced all
Stringwith an alias toVec<u8>to reduce the size of the contracts.