Added support of pallet-assets and chain extension for it.
#146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgreenx
requested review from
cmichi,
HCastano,
athei,
ascjones and
agryaznov
as code owners
xgreenx
added a commit
to xgreenx/chainextension-registry
that referenced
this pull request
Aug 20, 2022
The id of the chain extension is `0x48f6`. It is the first 2 bytes of the `blake2b` hash from the "pallet-assets-chain-extension@v0.1" string. The [chain extension](https://github.com/Supercolony-net/pallet-assets-chain-extension) created with usage of the [`obce`](https://github.com/Supercolony-net/obce) crate. The chain extension is not ready for production because it requires some additional changes on the `pallet-assets` side(some operations should be performed by the contract only if the contract is admin). But it is a matter of time, so I think we can register it and fix it with minor patches. Added support of the extension into [substrate-contract-node](paritytech/substrate-contracts-node#146) and into [OpenBrush](Supercolony-net/openbrush-contracts#168).
athei
reviewed
Aug 21, 2022
athei
approved these changes
Aug 22, 2022
Maybe this is a good time for us to start pinning to release branches instead of following |
HCastano
pushed a commit
to paritytech/chainextension-registry
that referenced
this pull request
Aug 22, 2022
* Add `pallet-assets` chain extension. The id of the chain extension is `0x48f6`. It is the first 2 bytes of the `blake2b` hash from the "pallet-assets-chain-extension@v0.1" string. The [chain extension](https://github.com/Supercolony-net/pallet-assets-chain-extension) created with usage of the [`obce`](https://github.com/Supercolony-net/obce) crate. The chain extension is not ready for production because it requires some additional changes on the `pallet-assets` side(some operations should be performed by the contract only if the contract is admin). But it is a matter of time, so I think we can register it and fix it with minor patches. Added support of the extension into [substrate-contract-node](paritytech/substrate-contracts-node#146) and into [OpenBrush](Supercolony-net/openbrush-contracts#168). * Update registry.json Co-authored-by: Alexander Theißen <alex.theissen@me.com> Co-authored-by: Alexander Theißen <alex.theissen@me.com>
xgreenx
force-pushed
the
feature/pallet-assets-chain-extension
branch
from
8e56886
to
96aaa05
Compare
|
If you update your extension to use the |
xgreenx
force-pushed
the
feature/pallet-assets-chain-extension
branch
from
96aaa05
to
dd8e9c9
Compare
athei
reviewed
Oct 11, 2022
runtime/Cargo.toml
Outdated
| @@ -51,6 +51,10 @@ pallet-contracts = { git = "https://github.com/paritytech/substrate", package = | |||
| pallet-contracts-primitives = { git = "https://github.com/paritytech/substrate", package = "pallet-contracts-primitives", default-features = false , branch = "polkadot-v0.9.29" } | |||
| pallet-contracts-rpc-runtime-api = { git = "https://github.com/paritytech/substrate", package = "pallet-contracts-rpc-runtime-api", default-features = false , branch = "polkadot-v0.9.29" } | |||
|
|
|||
| # Chain extension | |||
| pallet-assets = { git = "https://github.com/paritytech/substrate", package = "pallet-assets", default-features = false, branch = "polkadot-v0.9.29" } | |||
There was a problem hiding this comment.
Can you move that up to the other pallets? This is not a chain extension per se.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support of the chain extension for
pallet-assets. The extension requires additional changes on thepallet-assetsside to be ready for production. But we ca enable it already for testing=)