Skip to content

Commit

Permalink
Fix bib preview mobile (alshedivat#2359)
Browse files Browse the repository at this point in the history
[Reference](alshedivat#2352 (comment))

I'm not sure if the removal of `max-width: 90vw;` for all images causes
any side issues.
I could at least not find any. But having this properties will produce
unaligned preview sizes.
Help/testing is more than welcome.


# Before
<img width="364" alt="Bildschirmfoto 2024-04-21 um 14 17 51"
src="https://github.com/alshedivat/al-folio/assets/1998723/5ad1a4d7-dfe6-43f8-98ec-eae19dd991c2">

# After

<img width="364" alt="Bildschirmfoto 2024-04-21 um 14 21 53"
src="https://github.com/alshedivat/al-folio/assets/1998723/fb942403-a01f-42ec-95c6-697378ed0d92">
...
<img width="364" alt="Bildschirmfoto 2024-04-21 um 14 22 03"
src="https://github.com/alshedivat/al-folio/assets/1998723/1ddf43d8-98a8-421d-9f64-3352190c4bb8">
  • Loading branch information
CheariX authored and Suraj-Bhor committed Aug 13, 2024
1 parent c6a4bb1 commit 5bc69fa
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 14 deletions.
6 changes: 3 additions & 3 deletions _layouts/bib.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
---
<div class="row">
{% if site.enable_publication_thumbnails %}
<div class="col-sm-2 abbr">
<div class="col col-sm-2 abbr">
{%- if entry.abbr -%}
{%- if site.data.venues[entry.abbr] -%}
{% assign venue_style = null %}
{% if site.data.venues[entry.abbr].color != blank %}
{% assign venue_style = site.data.venues[entry.abbr].color | prepend: 'style="background-color:' | append: '"' %}
{%- endif -%}
<abbr
class="badge rounded"
class="badge rounded w-100"
{% if venue_style %}
{{ venue_style }}
{% endif -%}
Expand All @@ -22,7 +22,7 @@
{% endif %}
</abbr>
{% else %}
<abbr class="badge rounded">{{ entry.abbr }}</abbr>
<abbr class="badge rounded w-100">{{ entry.abbr }}</abbr>
{% endif %}
{% endif %}
{% if entry.preview %}
Expand Down
11 changes: 0 additions & 11 deletions _sass/_base.scss
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,6 @@ table.table a {
}
}

figure,
img {
max-width: 90vw;
}

blockquote {
background: var(--global-bg-color);
border-left: 5px solid var(--global-theme-color);
Expand Down Expand Up @@ -665,7 +660,6 @@ footer.sticky-bottom {
border-top: 1px solid var(--global-divider-color);
padding-top: 1rem;
margin-top: 2rem;
margin-bottom: -2rem;
text-align: right;
}

Expand All @@ -678,20 +672,15 @@ footer.sticky-bottom {
margin-bottom: 1rem;

.preview {
width: 100%;
min-width: 80px;
max-width: 200px;
}

.abbr {
height: 2rem;
margin-bottom: 0.5rem;

abbr {
display: inline-block;
background-color: var(--global-theme-color);
margin-bottom: 0.5rem;
width: 100%;

a {
color: white;
Expand Down

0 comments on commit 5bc69fa

Please sign in to comment.