-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bib preview mobile #2359
Fix bib preview mobile #2359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@broadcreate Thank you for testing it. That is interesting. Do you have any idea what the reason could be? I found the data on your website. But still, i cannot reproduce it with vanilla al-folio. |
@CheariX you can try it with my fork of al-folio. It currently has an issue with the layout in publications after introducing c4c066. I haven't got the time to fix this, but it would be nice if you could take a look at it. |
@george-gca : Your screenshot shows the desktop view. I assume you have the issue with the mobile view (?). I cannot reproduce the issue on your fork when I apply this PR. What is basically did:
The result looks as expected: @broadcreate Its a bit hard to understand what you exactly want to change in this PR. Are you sure that you applied this PR correctly? For example, on your screenshot, the years should be a bit higher, which I changed with cfef609 Before I we look how to "fix" this, it would be incredibly helpfull if we could reproduce your issue on vanilla al-folio.. Can you provide a bibtex entry+preview image that causes this issue on vanilla al-folio? |
After applying your PR, all the displays are normal now. The previous issues were likely caused by not refreshing the browser cache. Thanks! |
@george-gca I think we can merge this PR if there are no other concerns. |
Sorry I have been on a rush lately. Thanks for merging this. |
[Reference](alshedivat#2352 (comment)) I'm not sure if the removal of `max-width: 90vw;` for all images causes any side issues. I could at least not find any. But having this properties will produce unaligned preview sizes. Help/testing is more than welcome. # Before <img width="364" alt="Bildschirmfoto 2024-04-21 um 14 17 51" src="https://github.com/alshedivat/al-folio/assets/1998723/5ad1a4d7-dfe6-43f8-98ec-eae19dd991c2"> # After <img width="364" alt="Bildschirmfoto 2024-04-21 um 14 21 53" src="https://github.com/alshedivat/al-folio/assets/1998723/fb942403-a01f-42ec-95c6-697378ed0d92"> ... <img width="364" alt="Bildschirmfoto 2024-04-21 um 14 22 03" src="https://github.com/alshedivat/al-folio/assets/1998723/1ddf43d8-98a8-421d-9f64-3352190c4bb8">
[Reference](alshedivat#2352 (comment)) I'm not sure if the removal of `max-width: 90vw;` for all images causes any side issues. I could at least not find any. But having this properties will produce unaligned preview sizes. Help/testing is more than welcome. # Before <img width="364" alt="Bildschirmfoto 2024-04-21 um 14 17 51" src="https://github.com/alshedivat/al-folio/assets/1998723/5ad1a4d7-dfe6-43f8-98ec-eae19dd991c2"> # After <img width="364" alt="Bildschirmfoto 2024-04-21 um 14 21 53" src="https://github.com/alshedivat/al-folio/assets/1998723/fb942403-a01f-42ec-95c6-697378ed0d92"> ... <img width="364" alt="Bildschirmfoto 2024-04-21 um 14 22 03" src="https://github.com/alshedivat/al-folio/assets/1998723/1ddf43d8-98a8-421d-9f64-3352190c4bb8">
[Reference](alshedivat#2352 (comment)) I'm not sure if the removal of `max-width: 90vw;` for all images causes any side issues. I could at least not find any. But having this properties will produce unaligned preview sizes. Help/testing is more than welcome. # Before <img width="364" alt="Bildschirmfoto 2024-04-21 um 14 17 51" src="https://github.com/alshedivat/al-folio/assets/1998723/5ad1a4d7-dfe6-43f8-98ec-eae19dd991c2"> # After <img width="364" alt="Bildschirmfoto 2024-04-21 um 14 21 53" src="https://github.com/alshedivat/al-folio/assets/1998723/fb942403-a01f-42ec-95c6-697378ed0d92"> ... <img width="364" alt="Bildschirmfoto 2024-04-21 um 14 22 03" src="https://github.com/alshedivat/al-folio/assets/1998723/1ddf43d8-98a8-421d-9f64-3352190c4bb8">
[Reference](alshedivat#2352 (comment)) I'm not sure if the removal of `max-width: 90vw;` for all images causes any side issues. I could at least not find any. But having this properties will produce unaligned preview sizes. Help/testing is more than welcome. # Before <img width="364" alt="Bildschirmfoto 2024-04-21 um 14 17 51" src="https://github.com/alshedivat/al-folio/assets/1998723/5ad1a4d7-dfe6-43f8-98ec-eae19dd991c2"> # After <img width="364" alt="Bildschirmfoto 2024-04-21 um 14 21 53" src="https://github.com/alshedivat/al-folio/assets/1998723/fb942403-a01f-42ec-95c6-697378ed0d92"> ... <img width="364" alt="Bildschirmfoto 2024-04-21 um 14 22 03" src="https://github.com/alshedivat/al-folio/assets/1998723/1ddf43d8-98a8-421d-9f64-3352190c4bb8">
[Reference](alshedivat#2352 (comment)) I'm not sure if the removal of `max-width: 90vw;` for all images causes any side issues. I could at least not find any. But having this properties will produce unaligned preview sizes. Help/testing is more than welcome. # Before <img width="364" alt="Bildschirmfoto 2024-04-21 um 14 17 51" src="https://github.com/alshedivat/al-folio/assets/1998723/5ad1a4d7-dfe6-43f8-98ec-eae19dd991c2"> # After <img width="364" alt="Bildschirmfoto 2024-04-21 um 14 21 53" src="https://github.com/alshedivat/al-folio/assets/1998723/fb942403-a01f-42ec-95c6-697378ed0d92"> ... <img width="364" alt="Bildschirmfoto 2024-04-21 um 14 22 03" src="https://github.com/alshedivat/al-folio/assets/1998723/1ddf43d8-98a8-421d-9f64-3352190c4bb8">
I still have the issue with publication previews not rendering correctly on mobile - I updated my Not entirely sure what's causing these issues |
Have you tried the version from the tip of our main branch instead of the one from v0.12.0? |
[Reference](alshedivat#2352 (comment)) I'm not sure if the removal of `max-width: 90vw;` for all images causes any side issues. I could at least not find any. But having this properties will produce unaligned preview sizes. Help/testing is more than welcome. # Before <img width="364" alt="Bildschirmfoto 2024-04-21 um 14 17 51" src="https://github.com/alshedivat/al-folio/assets/1998723/5ad1a4d7-dfe6-43f8-98ec-eae19dd991c2"> # After <img width="364" alt="Bildschirmfoto 2024-04-21 um 14 21 53" src="https://github.com/alshedivat/al-folio/assets/1998723/fb942403-a01f-42ec-95c6-697378ed0d92"> ... <img width="364" alt="Bildschirmfoto 2024-04-21 um 14 22 03" src="https://github.com/alshedivat/al-folio/assets/1998723/1ddf43d8-98a8-421d-9f64-3352190c4bb8">
Reference
I'm not sure if the removal of
max-width: 90vw;
for all images causes any side issues.I could at least not find any. But having this properties will produce unaligned preview sizes.
Help/testing is more than welcome.
Before
After
...