Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breadcrumbs should have a nav wrapper in the example code to be WCAG compliant #101

Closed
boye-s opened this issue Aug 8, 2019 · 3 comments
Closed

Breadcrumbs should have a nav wrapper in the example code to be WCAG compliant #101

boye-s opened this issue Aug 8, 2019 · 3 comments

Comments

@boye-s
Copy link

boye-s commented Aug 8, 2019

According to WCAG 2.0 breadcrumbs should be surrounded by a nav element.
This should be a part of the design guide example for breadcrumbs.
Ref: https://www.w3.org/TR/wai-aria-practices/examples/breadcrumb/index.html
@eskilsen eskilsen mentioned this issue Oct 25, 2021
Merged
8 tasks
@VikingTristan VikingTristan reopened this Oct 25, 2021
@VikingTristan
Copy link
Contributor

@eskilsen Let the issue resolve itself when linked PR is merged.

@eskilsen
Copy link
Contributor

@eskilsen Let the issue resolve itself when linked PR is merged.
ah, I am noob
😞 🔫

eskilsen added a commit that referenced this issue Oct 28, 2021
@eskilsen
Merge pull request #575 from SwedbankPay/fix/issue-#101-breadcrumb
cb350b9 
Fix/issue #101 breadcrumb
@PhungNg PhungNg mentioned this issue Oct 28, 2021
Merged
@eskilsen
Copy link
Contributor

eskilsen commented Nov 9, 2021

Fixed 🚀

@eskilsen eskilsen closed this as completed Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@boye-s @eskilsen @VikingTristan