Release/7.1.0 #577
Release/7.1.0 #577
Conversation
Feature/add templates section
…rder Update focus styling on action links. Remove unnessasary comment
…nd update snapshots
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.3. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](unshiftio/url-parse@1.5.1...1.5.3) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…mple snapshot test.
…ed placement of disable-state-information.
Codecov Report
@@ Coverage Diff @@
## master #577 +/- ##
==========================================
+ Coverage 82.75% 82.88% +0.12%
==========================================
Files 204 213 +9
Lines 3641 3721 +80
Branches 762 800 +38
==========================================
+ Hits 3013 3084 +71
- Misses 537 544 +7
- Partials 91 93 +2
Continue to review full report at Codecov.
|
|
Size Change: +941 B (0%) Total Size: 748 kB
ℹ️ View Unchanged
|
|
Size Change: +1.07 kB (0%) Total Size: 748 kB
ℹ️ View Unchanged
|
Feature/fix forms pattern
|
Hmm, seems like the main github action workflow is crashing due to some azure deployment bug(?). |
There was a problem hiding this comment.
Looks very nice!
Haven't gotten through all of the files yet, but I've got some comments so far:
There are a couple of things that needs to be done before this can be released imo.
- Patterns route doesn't exist ( try going to https://design.stage.swedbankpay.com/release/7.1.0/patterns/forms )
- Check
generate-routes-copy-array.js
- Check
- Some images (e.g. login example images) needs new paths or webpack needs an update
- New changelog says we're now releasing DG light, but I am not sure we are quite there yet. Change changelog?
| <span className="h4 mb-0">Get started by setting up the Design Guide!</span> | ||
| <i className="material-icons material-icons-outlined ml-auto">arrow_forward</i> | ||
| </div> | ||
| </Link> |
There was a problem hiding this comment.
I would consider having just one loop and getting the "Get started" card to be rendered differently based on a property on the object instead.
Hard coding checks such as the "Get started" title check gives maintaining hell down the line.
| @@ -205,10 +204,10 @@ const HorizontalLogo = () => ( | |||
| <h2 id="horizontal-logo">Horizontal logo</h2> | |||
| <p></p> | |||
| <ComponentPreview language="html" showCasePanel codeFigure> | |||
| <img src={`${basename}img/payex-logo.svg`} alt="PayEx horizontal logo"/> | |||
| <img src={`${basename}designguide/assets/payex-logo.svg`} alt="PayEx horizontal logo"/> | |||
There was a problem hiding this comment.
Lets remove these paths after release.
The "designguide/assets" folder is no longer needed with the new node package
| export const guidelineList = [ | ||
| <>The <b>Product label</b> should display the name of the product the user is about to log in to.</>, | ||
| <><b>Log in</b> should always be the title of the login form.</>, | ||
| <>A section of links to <b>third party logins</b> can be added. Use a divider to separate it from the standard login section. It can be placed either before or after depending on the most common or desired way to login to the specific portal. </>, | ||
| <>The <b>required input fields</b> varies depending on the type of login. The amount of required fields differs depending on the authentication method. </>, | ||
| <><b>Remember me</b> is an optional field. When it is enabled it saves the data and present prefilled fields the next time the user is about to log in. </>, | ||
| <><b>Button</b> is used to allow the user to perform the login request.</>, | ||
| <><b>Additional help text</b> is optional and can be added underneath the button in order to provide the user with additional help or guidelines.</>, | ||
| <>Login forms should always have the <b>Swedbank pay logotype</b>.</> | ||
| ]; |
There was a problem hiding this comment.
a list of react templates to enable html elements? cool :)
| import React from "react"; | ||
| import { DocContainer } from "@docutils"; | ||
| import { Link } from "react-router-dom"; | ||
| import patternList from "@src/App/routes/patterns"; |
There was a problem hiding this comment.
nitpick we're importing routes here. For consistency with other files that import routes:
patternsRoutes?
Fixed by using an older azcliversion |
| }, | ||
| path: "/patterns", | ||
| entryCardText: "Learn about how to we set up different structures", | ||
| redirect: "/patterns/patterns", |
There was a problem hiding this comment.
nitpick for the future
Should paths just be /patterns ?
| margin-right: (-@base-margin-sm); | ||
| color: lighten(@text-color, 20%); | ||
| color: @medium-brown; |
There was a problem hiding this comment.
Brown color might not be suited for the payex brand, but it's very subtle atm so I guess it doesn't matter too much.
Changelog
[7.1.0] - 28.10.2021
Added
<nav>tags around Breadcrumbs ( Breadcrumbs should have a nav wrapper in the example code to be WCAG compliant #101 )Changed
Removed
<small>tag ( Tag small has two font-size rules #185 )Fixed