Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on Linux #56

Merged
merged 4 commits into from
Jul 30, 2017
Merged

Fix compilation on Linux #56

merged 4 commits into from
Jul 30, 2017

Conversation

jpsim
Copy link
Contributor

@jpsim jpsim commented Jul 29, 2017

No description provided.

@jpsim
Copy link
Contributor Author

jpsim commented Jul 29, 2017

I briefly started looking into making Sourcery build and run on Linux and this is the only dependency that doesn't support it (other than SwiftTryCatch, which isn't a strong requirement for Sourcery). Minimal changes required.

@@ -22,7 +22,8 @@ public enum StencilContext {
/// - Throws: `Parameters.Error`
public static func enrich(context: [String: Any],
parameters: [String],
environment: [String: String] = ProcessInfo().environment) throws -> [String: Any] {
environment: [String: String] =
ProcessInfo.processInfo.environment) throws -> [String: Any] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to either remove two spaces here or move this code back to the previous line and disable the line_length rule just this one to allow the CI to pass.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a SwiftLint bug. I've filed a PR to fix it here: realm/SwiftLint#1726

However, since that patch won't be available until a future SwiftLint release, I'll adapt my code to pass linting with the current release of SwiftLint.

@Liquidsoul
Copy link
Member

LGTM, thanks a lot for the changes!
We will try to make a release ASAP so you can continue your work on Sourcery on Linux 😉

@Liquidsoul Liquidsoul merged commit d79ede7 into SwiftGen:master Jul 30, 2017
@jpsim jpsim deleted the jp-linux branch July 30, 2017 10:16
AliSoftware added a commit that referenced this pull request Aug 12, 2017
@AliSoftware
Copy link
Contributor

@jpsim Released 2.0.1 with your fix 👍

--------------------------------------------------------------------------------
 🎉  Congrats

 🚀  StencilSwiftKit (2.0.1) successfully published
 📅  August 12th, 18:17
 🌎  https://cocoapods.org/pods/StencilSwiftKit
 👍  Tell your friends!
--------------------------------------------------------------------------------

@djbe djbe added this to the 2.0.0 milestone Aug 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants