Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite VerticalParameterAlignmentRule to be less fragile #1726

Merged
merged 3 commits into from
Jul 30, 2017

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Jul 30, 2017

rather than introduce a locally-scoped struct when a perfectly good
existing type will do.
@codecov-io
Copy link

codecov-io commented Jul 30, 2017

Codecov Report

Merging #1726 into master will decrease coverage by 0.01%.
The diff coverage is 91.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1726      +/-   ##
==========================================
- Coverage   87.45%   87.43%   -0.02%     
==========================================
  Files         209      209              
  Lines       10335    10335              
==========================================
- Hits         9038     9036       -2     
- Misses       1297     1299       +2
Impacted Files Coverage Δ
...amework/Rules/VerticalParameterAlignmentRule.swift 94.28% <91.3%> (-5.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 556ad4e...b87e3f4. Read the comment docs.

@SwiftLintBot
Copy link

SwiftLintBot commented Jul 30, 2017

1 Warning
⚠️ This PR may need tests.
41 Messages
📖 This PR fixed a violation in Aerial: /Aerial/Source/Controllers/Preferences.swift#L127:9: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/AssetLoaderDelegate.swift#L85:9: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 Linting Aerial with this PR took 0.37s vs 0.35s on master (5% slower)
📖 Linting Alamofire with this PR took 2.34s vs 2.35s on master (0% faster)
📖 Linting Firefox with this PR took 9.85s vs 10.03s on master (1% faster)
📖 Linting Kickstarter with this PR took 14.49s vs 14.44s on master (0% slower)
📖 Linting Moya with this PR took 0.7s vs 0.69s on master (1% slower)
📖 Linting Nimble with this PR took 1.35s vs 1.37s on master (1% faster)
📖 Linting Quick with this PR took 0.44s vs 0.44s on master (0% slower)
📖 Linting Realm with this PR took 2.05s vs 2.07s on master (0% faster)
📖 Linting SourceKitten with this PR took 0.77s vs 0.77s on master (0% slower)
📖 Linting Sourcery with this PR took 3.4s vs 3.39s on master (0% slower)
📖 This PR fixed a violation in Swift: /stdlib/public/core/ArrayBufferProtocol.swift#L79:3: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/core/ArrayBufferProtocol.swift#L144:3: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/core/CString.swift#L209:3: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/core/HashedCollectionsAnyHashableExtensions.swift#L20:3: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/core/ManagedBuffer.swift#L186:7: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/core/OptionSet.swift#L238:3: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/core/SetAlgebra.swift#L193:3: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/core/SliceBuffer.swift#L98:3: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/core/StringBuffer.swift#L97:3: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/core/String.swift#L664:3: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/core/StringCharacterView.swift#L673:3: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/core/StringCharacterView.swift#L754:3: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/core/StringCore.swift#L631:3: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/core/StringLegacy.swift#L287:3: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/core/StringLegacy.swift#L325:3: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/core/StringUnicodeScalarView.swift#L361:3: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Unicode.swift#L811:3: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/SDK/Foundation/NSItemProvider.swift#L25:3: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/SDK/Foundation/NSItemProvider.swift#L50:3: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/SDK/Foundation/NSStringAPI.swift#L1225:7: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/SDK/Foundation/NSStringAPI.swift#L1226:7: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/SDK/Foundation/NSStringAPI.swift#L1894:7: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/SDK/Foundation/NSStringAPI.swift#L1895:7: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/SDK/UIKit/UIKit.swift#L145:8: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/SDK/UIKit/UIKit.swift#L167:8: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/SDK/UIKit/UIKit.swift#L323:3: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 This PR fixed a violation in Swift: /stdlib/public/SDK/UIKit/UIKit.swift#L367:3: warning: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
📖 Linting Swift with this PR took 9.79s vs 9.86s on master (0% faster)
📖 Linting WordPress with this PR took 9.21s vs 9.3s on master (0% faster)

Generated by 🚫 Danger

@jpsim jpsim merged commit 89e2ff3 into master Jul 30, 2017
@jpsim jpsim deleted the jp-fix-vertical-parameter-alignment-rule branch July 30, 2017 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants