Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup work from moving renku notebooks #303

Open
1 of 10 tasks
olevski opened this issue Jul 15, 2024 · 0 comments
Open
1 of 10 tasks

Followup work from moving renku notebooks #303

olevski opened this issue Jul 15, 2024 · 0 comments

Comments

@olevski
Copy link
Member

olevski commented Jul 15, 2024

Leftover from renku notebooks code move:

Tasks

  • notebooks: convert http calls to direct calls #396
  • Implement additional API input validation #398
  • Move operational logic from blueprints to core #399
  • Evaluate trust-manager to replace renku/certificates #400
  • components/renku_data_services/notebooks/api/notebooks.py L677: the error message could be more descriptive, if I saw this in a log, I wouldn't know what the cause was.
  • components/renku_data_services/notebooks/api/notebooks.py L683 and 685: isn't this what empty is for?
  • components/renku_data_services/notebooks/config/init.py: TODO for later, move out of init.py
  • components/renku_data_services/notebooks/util/authn.py: We need to refactor this code. we create a RegisteredUser no matter what, check if authenticated is True (which it is if all required headers are present, but we don't actually check the content of the headers in the RegisteredUser init) and if not create an AnonymousUser. This seems pretty brittle and is a weird way for this code to be written. and if I read it correctly, I could put whatever I want in those headers and it would consider it a registered user?
  • Rename NotebooksNewBP to SessionsBP or something similar.
  • Improve makefile and dev workflow for new sessions

Related to #301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant