Notebook: refactor blueprint business logic to core #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgaist
force-pushed
the
feature/notebook-refactor
branch
from
b08ae40
to
eeb195a
Compare
sgaist
changed the title
olevski
force-pushed
the
release-amaltheas-migration
branch
6 times, most recently
from
d2b2d48
to
a932966
Compare
While most of the tests are written in functions, moving those requiring a cluster into a class allows the use of a class scoped fixtures for the cluster creation. This has the advantage of reducing the run time of the tests since the cluster will only be created for tests that actually requires one so if someone needs to re-test a particular endpoint that has nothing to do with kubernetes, they will not incur the useless creation and destruction time which is not trivial. The class has been put in utils because it will be used later for the sessions tests.
No tests requiring a cluster are currently run.
This allows to use a permanent cluster during development so running tests does incure the setup and teardown delay.
This happened during cherry-pick conflict cleanup.
sgaist
force-pushed
the
feature/notebook-refactor
branch
from
847d88f
to
e96267e
Compare
olevski
approved these changes
Oct 17, 2024
olevski
pushed a commit
that referenced
this pull request
Oct 22, 2024
The move of business logic out of the blueprint allows the code to be reusable without having to go through the web API. It also allows for tests to be added without the web complexity. Tests have been refactored so that test clusters will be created only when testing endpoints that actually require a cluster. This has the advantage of speeding up test time. This is especially useful when doing development. Finally, a new test option has been added so one can use a local cluster in place of re-creating one each time tests are run.
olevski
pushed a commit
that referenced
this pull request
Oct 28, 2024
The move of business logic out of the blueprint allows the code to be reusable without having to go through the web API. It also allows for tests to be added without the web complexity. Tests have been refactored so that test clusters will be created only when testing endpoints that actually require a cluster. This has the advantage of speeding up test time. This is especially useful when doing development. Finally, a new test option has been added so one can use a local cluster in place of re-creating one each time tests are run.
olevski
pushed a commit
that referenced
this pull request
Oct 28, 2024
The move of business logic out of the blueprint allows the code to be reusable without having to go through the web API. It also allows for tests to be added without the web complexity. Tests have been refactored so that test clusters will be created only when testing endpoints that actually require a cluster. This has the advantage of speeding up test time. This is especially useful when doing development. Finally, a new test option has been added so one can use a local cluster in place of re-creating one each time tests are run.
olevski
pushed a commit
that referenced
this pull request
Oct 30, 2024
The move of business logic out of the blueprint allows the code to be reusable without having to go through the web API. It also allows for tests to be added without the web complexity. Tests have been refactored so that test clusters will be created only when testing endpoints that actually require a cluster. This has the advantage of speeding up test time. This is especially useful when doing development. Finally, a new test option has been added so one can use a local cluster in place of re-creating one each time tests are run.
olevski
pushed a commit
that referenced
this pull request
Oct 31, 2024
The move of business logic out of the blueprint allows the code to be reusable without having to go through the web API. It also allows for tests to be added without the web complexity. Tests have been refactored so that test clusters will be created only when testing endpoints that actually require a cluster. This has the advantage of speeding up test time. This is especially useful when doing development. Finally, a new test option has been added so one can use a local cluster in place of re-creating one each time tests are run.
olevski
pushed a commit
that referenced
this pull request
Nov 1, 2024
The move of business logic out of the blueprint allows the code to be reusable without having to go through the web API. It also allows for tests to be added without the web complexity. Tests have been refactored so that test clusters will be created only when testing endpoints that actually require a cluster. This has the advantage of speeding up test time. This is especially useful when doing development. Finally, a new test option has been added so one can use a local cluster in place of re-creating one each time tests are run.
olevski
pushed a commit
that referenced
this pull request
Nov 4, 2024
The move of business logic out of the blueprint allows the code to be reusable without having to go through the web API. It also allows for tests to be added without the web complexity. Tests have been refactored so that test clusters will be created only when testing endpoints that actually require a cluster. This has the advantage of speeding up test time. This is especially useful when doing development. Finally, a new test option has been added so one can use a local cluster in place of re-creating one each time tests are run.
olevski
pushed a commit
that referenced
this pull request
Nov 6, 2024
The move of business logic out of the blueprint allows the code to be reusable without having to go through the web API. It also allows for tests to be added without the web complexity. Tests have been refactored so that test clusters will be created only when testing endpoints that actually require a cluster. This has the advantage of speeding up test time. This is especially useful when doing development. Finally, a new test option has been added so one can use a local cluster in place of re-creating one each time tests are run.
olevski
pushed a commit
that referenced
this pull request
Nov 8, 2024
The move of business logic out of the blueprint allows the code to be reusable without having to go through the web API. It also allows for tests to be added without the web complexity. Tests have been refactored so that test clusters will be created only when testing endpoints that actually require a cluster. This has the advantage of speeding up test time. This is especially useful when doing development. Finally, a new test option has been added so one can use a local cluster in place of re-creating one each time tests are run.
olevski
pushed a commit
that referenced
this pull request
Nov 11, 2024
The move of business logic out of the blueprint allows the code to be reusable without having to go through the web API. It also allows for tests to be added without the web complexity. Tests have been refactored so that test clusters will be created only when testing endpoints that actually require a cluster. This has the advantage of speeding up test time. This is especially useful when doing development. Finally, a new test option has been added so one can use a local cluster in place of re-creating one each time tests are run.
olevski
pushed a commit
that referenced
this pull request
Nov 11, 2024
The move of business logic out of the blueprint allows the code to be reusable without having to go through the web API. It also allows for tests to be added without the web complexity. Tests have been refactored so that test clusters will be created only when testing endpoints that actually require a cluster. This has the advantage of speeding up test time. This is especially useful when doing development. Finally, a new test option has been added so one can use a local cluster in place of re-creating one each time tests are run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR extracts the business logic of the JupyterServer related endpoints from the notebooks blueprints to
core.pyso that it follows other modules implementation.Issue ticket number and link
Part of #303
Fixes #399