feat: run notebooks in data service #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olevski
force-pushed
the
feat-run-notebook-service-simplify-history
branch
from
dcc7d03
to
545b3c6
Compare
olevski
force-pushed
the
feat-expand-environments-specification
branch
4 times, most recently
from
8872560
to
4eb2c24
Compare
olevski
force-pushed
the
feat-run-notebook-service-simplify-history
branch
from
545b3c6
to
15cc4e9
Compare
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Aug 27, 2024
olevski
force-pushed
the
feat-run-notebook-service-simplify-history
branch
from
15cc4e9
to
3a28e4e
Compare
olevski
force-pushed
the
feat-expand-environments-specification
branch
from
4eb2c24
to
d76ef5e
Compare
olevski
force-pushed
the
feat-run-notebook-service-simplify-history
branch
from
3a28e4e
to
f4455bc
Compare
olevski
temporarily deployed
to
renku-ci-ds-375
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ds-375.dev.renku.ch |
olevski
force-pushed
the
feat-expand-environments-specification
branch
from
d76ef5e
to
03223a7
Compare
olevski
force-pushed
the
feat-run-notebook-service-simplify-history
branch
from
f4455bc
to
43b61be
Compare
olevski
temporarily deployed
to
renku-ci-ds-375
GitHub Actions
Inactive
olevski
force-pushed
the
feat-run-notebook-service-simplify-history
branch
from
43b61be
to
e221f61
Compare
olevski
temporarily deployed
to
renku-ci-ds-375
GitHub Actions
Inactive
olevski
force-pushed
the
feat-run-notebook-service-simplify-history
branch
from
e221f61
to
bb8625d
Compare
olevski
temporarily deployed
to
renku-ci-ds-375
GitHub Actions
Inactive
olevski
force-pushed
the
feat-expand-environments-specification
branch
from
03223a7
to
09ca8b3
Compare
olevski
force-pushed
the
feat-run-notebook-service-simplify-history
branch
from
bb8625d
to
6c4468d
Compare
olevski
temporarily deployed
to
renku-ci-ds-375
GitHub Actions
Inactive
Panaetius
force-pushed
the
feat-expand-environments-specification
branch
from
09ca8b3
to
4eb2c24
Compare
olevski
force-pushed
the
feat-expand-environments-specification
branch
from
4eb2c24
to
09ca8b3
Compare
olevski
had a problem deploying
to
renku-ci-ds-375
GitHub Actions
Failure
olevski
temporarily deployed
to
renku-ci-ds-375
GitHub Actions
Inactive
olevski
force-pushed
the
feat-run-notebook-service-simplify-history
branch
from
ecb9c88
to
9941e20
Compare
olevski
temporarily deployed
to
renku-ci-ds-375
GitHub Actions
Inactive
olevski
force-pushed
the
feat-run-notebook-service-simplify-history
branch
from
9941e20
to
9e88bad
Compare
olevski
temporarily deployed
to
renku-ci-ds-375
GitHub Actions
Inactive
olevski
force-pushed
the
feat-run-notebook-service-simplify-history
branch
from
9e88bad
to
1a44f2e
Compare
olevski
temporarily deployed
to
renku-ci-ds-375
GitHub Actions
Inactive
Panaetius
approved these changes
Sep 23, 2024
sgaist
reviewed
Sep 23, 2024
components/renku_data_services/notebooks/api/amalthea_patches/init_containers.py
Show resolved
Hide resolved
components/renku_data_services/notebooks/api/classes/k8s_client.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch>
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
olevski
added a commit
that referenced
this pull request
Sep 23, 2024
Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch>
olevski
added a commit
that referenced
this pull request
Sep 23, 2024
Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch> squashme: resolve package version conflicts
olevski
added a commit
that referenced
this pull request
Sep 23, 2024
Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch> squashme: resolve package version conflicts feat: update and expand apispec for environments chore: filter environments by owner type squashme: address comments feat!: expand environment specification This is a breaking change in the API. chore: add tests and minor fixes chore: test the global environments migration chore: fix tests chore: minor improvements to db session handling squashme: minor fix squashme: fixups for conflict resolutuion after merge squashme: fix failing tests chore: address comments feat: add command and args to environments squashme: notebooks changes This includes major edits to the notebooks code to work with the data service. chore: resolve changes from conflict resolution chore: do not use the complicated notebooks gitlab header The gitlab credentials header from the notebooks is really complicated. We used it here just to get the access token expiry. I modified the gateway to now pass in an extra header value to indicate the gitlab token expiry. squashme: handle per secret adoption in amalthea squashme: fix parsing of PosixPath in orm squashme: display the right status and state squashme: address comments from review pt1 refactor: make APIUser a frozen dataclass As there is no reason that these object shall be modified within the services, it simplifies its handling. squashme: address comments from review pt2 squashme: fixups from rebasing squashme: use PurePosixPath for workdir and mount squashme: add saved cloud storage model
olevski
added a commit
that referenced
this pull request
Sep 23, 2024
Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch> squashme: resolve package version conflicts feat: update and expand apispec for environments chore: filter environments by owner type squashme: address comments feat!: expand environment specification This is a breaking change in the API. chore: add tests and minor fixes chore: test the global environments migration chore: fix tests chore: minor improvements to db session handling squashme: minor fix squashme: fixups for conflict resolutuion after merge squashme: fix failing tests chore: address comments feat: add command and args to environments squashme: notebooks changes This includes major edits to the notebooks code to work with the data service. chore: resolve changes from conflict resolution chore: do not use the complicated notebooks gitlab header The gitlab credentials header from the notebooks is really complicated. We used it here just to get the access token expiry. I modified the gateway to now pass in an extra header value to indicate the gitlab token expiry. squashme: handle per secret adoption in amalthea squashme: fix parsing of PosixPath in orm squashme: display the right status and state squashme: address comments from review pt1 refactor: make APIUser a frozen dataclass As there is no reason that these object shall be modified within the services, it simplifies its handling. squashme: address comments from review pt2 squashme: fixups from rebasing squashme: use PurePosixPath for workdir and mount squashme: add saved cloud storage model
olevski
added a commit
that referenced
this pull request
Sep 23, 2024
Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch> squashme: resolve package version conflicts feat: run notebooks in data service (#375) Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch> squashme: resolve package version conflicts feat: update and expand apispec for environments chore: filter environments by owner type squashme: address comments feat!: expand environment specification This is a breaking change in the API. chore: add tests and minor fixes chore: test the global environments migration chore: fix tests chore: minor improvements to db session handling squashme: minor fix squashme: fixups for conflict resolutuion after merge squashme: fix failing tests chore: address comments feat: add command and args to environments squashme: notebooks changes This includes major edits to the notebooks code to work with the data service. chore: resolve changes from conflict resolution chore: do not use the complicated notebooks gitlab header The gitlab credentials header from the notebooks is really complicated. We used it here just to get the access token expiry. I modified the gateway to now pass in an extra header value to indicate the gitlab token expiry. squashme: handle per secret adoption in amalthea squashme: fix parsing of PosixPath in orm squashme: display the right status and state squashme: address comments from review pt1 refactor: make APIUser a frozen dataclass As there is no reason that these object shall be modified within the services, it simplifies its handling. squashme: address comments from review pt2 squashme: fixups from rebasing squashme: use PurePosixPath for workdir and mount squashme: add saved cloud storage model
olevski
added a commit
that referenced
this pull request
Sep 23, 2024
Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch> squashme: resolve package version conflicts feat: run notebooks in data service (#375) Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch> squashme: resolve package version conflicts feat: run notebooks in data service (#375) Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch> squashme: resolve package version conflicts feat: update and expand apispec for environments chore: filter environments by owner type squashme: address comments feat!: expand environment specification This is a breaking change in the API. chore: add tests and minor fixes chore: test the global environments migration chore: fix tests chore: minor improvements to db session handling squashme: minor fix squashme: fixups for conflict resolutuion after merge squashme: fix failing tests chore: address comments feat: add command and args to environments squashme: notebooks changes This includes major edits to the notebooks code to work with the data service. chore: resolve changes from conflict resolution chore: do not use the complicated notebooks gitlab header The gitlab credentials header from the notebooks is really complicated. We used it here just to get the access token expiry. I modified the gateway to now pass in an extra header value to indicate the gitlab token expiry. squashme: handle per secret adoption in amalthea squashme: fix parsing of PosixPath in orm squashme: display the right status and state squashme: address comments from review pt1 refactor: make APIUser a frozen dataclass As there is no reason that these object shall be modified within the services, it simplifies its handling. squashme: address comments from review pt2 squashme: fixups from rebasing squashme: use PurePosixPath for workdir and mount squashme: add saved cloud storage model
olevski
added a commit
that referenced
this pull request
Sep 25, 2024
Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch> squashme: resolve package version conflicts
olevski
added a commit
that referenced
this pull request
Sep 27, 2024
Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch> squashme: resolve package version conflicts
olevski
added a commit
that referenced
this pull request
Oct 2, 2024
Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch> squashme: resolve package version conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes major edits to the notebooks code to work with the data service.
/deploy renku=feat-jupyter-free-sessions amalthea-sessions=feat-add-cloud-storage renku-notebooks=feat-jupyter-free-sessions renku-gateway=feat-add-renku-refresh-token-for-data-service renku-ui=andrea/custom-launcher-jupyter-free extra-values=amalthea-sessions.deployCrd=false #notest