Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not get disabled keycloak users #393

Merged
merged 40 commits into from
Oct 9, 2024

Conversation

wesjdj
Copy link
Contributor

@wesjdj wesjdj commented Sep 10, 2024

Enables removing disabled Keycloak user accounts from data services and Renku 2.0's search.

  1. Modifies background jobs not to sync any user accounts disabled in Keycloak to data services.
  2. Adds an API endpoint to allow for the deletion of user accounts from data services by providing the associated Keycloak user ID.

When a user account is deleted using the new API endpoint, the user no longer appears in Renku 2.0's search, and references of the user are removed from the authz database.

/deploy

@coveralls
Copy link

coveralls commented Sep 10, 2024

Pull Request Test Coverage Report for Build 11237903971

Details

  • 59 of 64 (92.19%) changed or added relevant lines in 7 files are covered.
  • 7 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.002%) to 90.524%

Changes Missing Coverage Covered Lines Changed/Added Lines %
bases/renku_data_services/background_jobs/config.py 1 2 50.0%
components/renku_data_services/authz/authz.py 20 21 95.24%
components/renku_data_services/users/kc_api.py 0 1 0.0%
components/renku_data_services/users/db.py 24 26 92.31%
Files with Coverage Reduction New Missed Lines %
bases/renku_data_services/background_jobs/config.py 1 53.85%
components/renku_data_services/authz/authz.py 1 91.0%
components/renku_data_services/storage/blueprints.py 1 94.29%
components/renku_data_services/crc/blueprints.py 2 93.81%
components/renku_data_services/crc/db.py 2 87.58%
Totals Coverage Status
Change from base Build 11231692484: -0.002%
Covered Lines: 9591
Relevant Lines: 10595

💛 - Coveralls

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ds-393.dev.renku.ch

@leafty leafty self-requested a review October 8, 2024 14:46
@wesjdj wesjdj merged commit 5b095d7 into main Oct 9, 2024
43 of 55 checks passed
@wesjdj wesjdj deleted the feat-do-not-sync-disabled-kc-users branch October 9, 2024 15:13
@RenkuBot
Copy link
Contributor

RenkuBot commented Oct 9, 2024

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants