feat: link data connectors to projects #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the `project_slugs` table to `entity_slugs` and `project_slugs_old` to `entity_slugs_old`. This is done to prepare for more entity types to be namespaced. Note: the sequence migration has been tested: 1. Force migration revision to be `9058bf0a1a12` (before this). 2. Deploy with image tag `renku/renku-data-service:sha-345a1bb` (current `main`) and run `alembic check` and `alembic heads` to verify the DB is before this change. 3. Create some projects. 4. Re-deploy this PR and check that migration revision is `a11752a5afba` (after this). 5. Create more projects.
Introduce namespaced data connectors for Renku 2.0. Details: * Remove API routes for `/storages_v2` * Add API routes for `/data_connectors` * Add `data_connectors` table * Drop the `storage_secrets` table * Add `data_connectors_secrets` table
leafty
force-pushed
the
leafty/feat-namespaced-data-connectors-4
branch
from
44e1704
to
e06d710
Compare
leafty
temporarily deployed
to
renku-ci-ds-410
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ds-410.dev.renku.ch |
leafty
temporarily deployed
to
renku-ci-ds-410
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ds-410
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ds-410
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ds-410
GitHub Actions
Inactive
Fixes deleting storage configuration fields by setting them to `null`.
…to leafty/feat-namespaced-data-connectors-3 # Conflicts: # test/bases/renku_data_services/data_api/test_data_connectors.py
…ectors-3' into leafty/feat-namespaced-data-connectors-4
leafty
temporarily deployed
to
renku-ci-ds-410
GitHub Actions
Inactive
Co-authored-by: Tasko Olevski <olevski90@gmail.com>
…to leafty/feat-namespaced-data-connectors-3 # Conflicts: # components/renku_data_services/app_config/config.py # components/renku_data_services/data_connectors/api.spec.yaml # components/renku_data_services/data_connectors/apispec.py # components/renku_data_services/data_connectors/blueprints.py # components/renku_data_services/data_connectors/db.py # components/renku_data_services/data_connectors/models.py # test/bases/renku_data_services/data_api/test_data_connectors.py
…eat-namespaced-data-connectors-4
leafty
temporarily deployed
to
renku-ci-ds-410
GitHub Actions
Inactive
Base automatically changed from
leafty/feat-namespaced-data-connectors-3
to
leafty/build-data-connectors
September 23, 2024 12:39
…to leafty/feat-namespaced-data-connectors-4 # Conflicts: # components/renku_data_services/authz/authz.py # components/renku_data_services/data_connectors/apispec.py # components/renku_data_services/data_connectors/db.py # components/renku_data_services/data_connectors/models.py
leafty
temporarily deployed
to
renku-ci-ds-410
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ds-410
GitHub Actions
Inactive
m-alisafaee
requested changes
Sep 27, 2024
| ).one_or_none() | ||
| if project is None: | ||
| raise errors.MissingResourceError( | ||
| message=f"Project with id '{link.project_id}' does not exist or you do not have access to it." |
leafty
temporarily deployed
to
renku-ci-ds-410
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ds-410
GitHub Actions
Inactive
m-alisafaee
approved these changes
Sep 30, 2024
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
leafty
added a commit
that referenced
this pull request
Sep 30, 2024
Adds the possibility to link a data connector to a project. Details: * Add API to link a data connector to a project * Add API to list projects connected to a data connector * Add API to list data connectors connected to a project Note that `read` permissions are cascaded to direct members of the connected project. * Creating a link from a private data connector to a project requires the `editor` role on both sides of the link. * Creating a link from a public data connector to a project requires the `editor` role on the project. * Removing a link requires either the `editor` role on the project or the `owner` role on the data connector.
leafty
added a commit
that referenced
this pull request
Sep 30, 2024
Adds the possibility to link a data connector to a project. Details: * Add API to link a data connector to a project * Add API to list projects connected to a data connector * Add API to list data connectors connected to a project Note that `read` permissions are cascaded to direct members of the connected project. * Creating a link from a private data connector to a project requires the `editor` role on both sides of the link. * Creating a link from a public data connector to a project requires the `editor` role on the project. * Removing a link requires either the `editor` role on the project or the `owner` role on the data connector.
leafty
added a commit
that referenced
this pull request
Oct 4, 2024
Adds the possibility to link a data connector to a project. Details: * Add API to link a data connector to a project * Add API to list projects connected to a data connector * Add API to list data connectors connected to a project Note that `read` permissions are cascaded to direct members of the connected project. * Creating a link from a private data connector to a project requires the `editor` role on both sides of the link. * Creating a link from a public data connector to a project requires the `editor` role on the project. * Removing a link requires either the `editor` role on the project or the `owner` role on the data connector.
leafty
added a commit
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging into
leafty/build-data-connectors(feature branch).Adds the possibility to link a data connector to a project.
Details:
Note that
readpermissions are cascaded to direct members of the connected project.editorrole on both sides of the link.editorrole on the project.editorrole on the project or theownerrole on the data connector./deploy