feat: migrate storages_v2 to data_connectors #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the `project_slugs` table to `entity_slugs` and `project_slugs_old` to `entity_slugs_old`. This is done to prepare for more entity types to be namespaced. Note: the sequence migration has been tested: 1. Force migration revision to be `9058bf0a1a12` (before this). 2. Deploy with image tag `renku/renku-data-service:sha-345a1bb` (current `main`) and run `alembic check` and `alembic heads` to verify the DB is before this change. 3. Create some projects. 4. Re-deploy this PR and check that migration revision is `a11752a5afba` (after this). 5. Create more projects.
Introduce namespaced data connectors for Renku 2.0. Details: * Remove API routes for `/storages_v2` * Add API routes for `/data_connectors` * Add `data_connectors` table * Drop the `storage_secrets` table * Add `data_connectors_secrets` table
Fixes deleting storage configuration fields by setting them to `null`.
…to leafty/feat-namespaced-data-connectors-3 # Conflicts: # test/bases/renku_data_services/data_api/test_data_connectors.py
…ectors-3' into leafty/feat-namespaced-data-connectors-4
…ectors-4' into leafty/feat-namespaced-data-connectors-5
…ectors-4' into leafty/feat-namespaced-data-connectors-5
leafty
force-pushed
the
leafty/feat-namespaced-data-connectors-5
branch
from
3c45ace
to
d064f7b
Compare
Base automatically changed from
leafty/feat-namespaced-data-connectors-5
to
leafty/build-data-connectors
October 4, 2024 07:17
leafty
force-pushed
the
leafty/build-data-connectors
branch
from
c5820ef
to
b772eef
Compare
…to leafty/feat-namespaced-data-connectors-6 # Conflicts: # Makefile # bases/renku_data_services/data_api/app.py # components/renku_data_services/app_config/config.py # components/renku_data_services/authz/authz.py # components/renku_data_services/base_api/misc.py # components/renku_data_services/data_connectors/api.spec.yaml # components/renku_data_services/data_connectors/apispec.py # components/renku_data_services/data_connectors/blueprints.py # components/renku_data_services/data_connectors/core.py # components/renku_data_services/data_connectors/db.py # components/renku_data_services/data_connectors/models.py # components/renku_data_services/migrations/versions/a11752a5afba_migrate_to_entity_slugs.py # components/renku_data_services/project/apispec.py # components/renku_data_services/storage/db.py # test/bases/renku_data_services/data_api/test_data_connectors.py
…ectors-7' into leafty/feat-namespaced-data-connectors-6
…to leafty/feat-namespaced-data-connectors-6 # Conflicts: # components/renku_data_services/migrations/versions/3cf2adf9896b_add_data_connectors.py
leafty
changed the title
Panaetius
requested changes
Oct 9, 2024
components/renku_data_services/data_connectors/migration_utils.py
Outdated
Show resolved
Hide resolved
Panaetius
approved these changes
Oct 9, 2024
Panaetius
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging into
leafty/build-data-connectors(feature branch).Add a background job to migrate "Data Sources" (
/storages_v2) to "Data Connectors" (/data_connectors). Each storage item has a new data connector created and linked to the source project.See for manual testing: SwissDataScienceCenter/renku#3797
Logs from migration job: