Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: autostart custom notebook (#1781) #1905

Merged
merged 3 commits into from
Jun 21, 2022

Conversation

andre-code
Copy link
Contributor

@andre-code andre-code commented Jun 14, 2022

PR to include the path to the notebook file in the modal to share the session link.

How it works

share session link

Closes #1781

/deploy #persist

@andre-code andre-code changed the title feat: autostart-custom-notebook feat: autostart custom notebook Jun 14, 2022
@andre-code andre-code temporarily deployed to renku-ci-ui-1905 June 14, 2022 14:08 Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-1905.dev.renku.ch

@andre-code andre-code force-pushed the 1781-autostart-in-particular-notebook branch from 7f9f68c to 74639b8 Compare June 14, 2022 15:29
@andre-code andre-code temporarily deployed to renku-ci-ui-1905 June 14, 2022 15:30 Inactive
@ciyer
Copy link
Contributor

ciyer commented Jun 15, 2022

While adding this feature, could you fix this rendering problem?

image

@andre-code andre-code force-pushed the 1781-autostart-in-particular-notebook branch from 74639b8 to 9c954e1 Compare June 15, 2022 08:09
@andre-code andre-code temporarily deployed to renku-ci-ui-1905 June 15, 2022 08:10 Inactive
@andre-code andre-code force-pushed the 1781-autostart-in-particular-notebook branch from 9c954e1 to 0256971 Compare June 15, 2022 17:42
@andre-code andre-code temporarily deployed to renku-ci-ui-1905 June 15, 2022 17:42 Inactive
@andre-code andre-code changed the title feat: autostart custom notebook feat: autostart custom notebook (#1781) Jun 16, 2022
@andre-code andre-code force-pushed the 1781-autostart-in-particular-notebook branch from 0256971 to efe32b5 Compare June 16, 2022 08:27
@andre-code andre-code temporarily deployed to renku-ci-ui-1905 June 16, 2022 08:28 Inactive
@andre-code andre-code marked this pull request as ready for review June 16, 2022 10:04
@andre-code andre-code requested a review from a team as a code owner June 16, 2022 10:04
@andre-code andre-code force-pushed the 1781-autostart-in-particular-notebook branch from efe32b5 to 69f3743 Compare June 16, 2022 10:06
@andre-code andre-code temporarily deployed to renku-ci-ui-1905 June 16, 2022 10:07 Inactive
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very useful!

After discussions, I have some requests to make a few changes.

  1. The link should be available for any file in the project, not just notebooks
  2. For the case that the user does not want to specify the branch/commit, I think a simpler UX where the pop-up appears over the file browser would be better.

image

Only if the user asks to specify the branch/commit should they get redirected to the "Start notebook" page.

  1. Let us say which file you will return to if you do get redirected to the "Start notebook" page.

image

if (this.props.filePath.endsWith(".ipynb"))
buttonJupyter = (<JupyterButton {...this.props} file={filePath} />);
let buttonJupyter, buttonShareLinkSession = null;
if (this.props.filePath.endsWith(".ipynb")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature should be available for any file, not just notebooks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, added in the last commit

Comment on lines 1353 to 1356
<FormGroup key="notebook-file-path">
<Label><b>Notebook:</b> {notebookFilePath}</Label>
</FormGroup>
) : null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be nicer as text.

Suggested change
<FormGroup key="notebook-file-path">
<Label><b>Notebook:</b> {notebookFilePath}</Label>
</FormGroup>
) : null;
<FormGroup key="notebook-file-path">
<Label>With <b>{notebookFilePath}</b> initially open</Label>
</FormGroup>
) : null;

@andre-code andre-code temporarily deployed to renku-ci-ui-1905 June 20, 2022 07:14 Inactive
@andre-code
Copy link
Contributor Author

@ciyer Thanks for your review, I really like the suggestion. Please find the implementation of this in the latest commit.

@ciyer ciyer force-pushed the 1781-autostart-in-particular-notebook branch from 8f59f3a to 62849c0 Compare June 20, 2022 08:24
@ciyer ciyer temporarily deployed to renku-ci-ui-1905 June 20, 2022 08:24 Inactive
ciyer
ciyer previously approved these changes Jun 20, 2022
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works very nicely!

There are some improvements to the session start page that should be made to make this clearer, but I think it would be better to incorporate that into the broader session redesign in #1805.

Once the tests pass, I think this can be merged.

@ciyer ciyer temporarily deployed to renku-ci-ui-1905 June 20, 2022 10:17 Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-1905 June 20, 2022 13:09 Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-1905 June 21, 2022 08:38 Inactive
@andre-code andre-code force-pushed the 1781-autostart-in-particular-notebook branch from 62849c0 to 7c7f30e Compare June 21, 2022 10:15
@andre-code andre-code temporarily deployed to renku-ci-ui-1905 June 21, 2022 10:15 Inactive
ciyer
ciyer previously approved these changes Jun 21, 2022
@andre-code andre-code force-pushed the 1781-autostart-in-particular-notebook branch from a771707 to f6d1e64 Compare June 21, 2022 11:03
@andre-code andre-code deployed to renku-ci-ui-1905 June 21, 2022 11:07 Active
@andre-code andre-code merged commit ec155aa into master Jun 21, 2022
@andre-code andre-code deleted the 1781-autostart-in-particular-notebook branch June 21, 2022 12:51
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autostart URLs should allow to directly open a notebook
3 participants