Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autostart URLs should allow to directly open a notebook #1781

Closed
lorenzo-cavazzi opened this issue Apr 8, 2022 · 1 comment · Fixed by #1905
Closed

Autostart URLs should allow to directly open a notebook #1781

lorenzo-cavazzi opened this issue Apr 8, 2022 · 1 comment · Fixed by #1905
Assignees
Milestone

Comments

@lorenzo-cavazzi
Copy link
Member

lorenzo-cavazzi commented Apr 8, 2022

Motivation

We already open JupyterHub sessions directly into a notebook from the file viewer.
Some users expressed interest in having quickstart links for the sessions doing the same thing (@rokroskar ).

Proposal

Technically it is not too difficult, although this may need some coordination with renku-notebooks since the current mechanism is based on JupyterLab, and that may not be there anymore for R-based images.

Add a button to the File view, when the user is looking at a notebook to create a sharable link to start the notebook in a session:

image

This probably belongs to the "Create shareable link" modal. An idea could be adding an expandable menu that allows selecting (through a radio button) a target notebook to open.
When clicking on [set default notebook], the UI should scan the files in the project and identify the notebooks, listing them (verify the feasibility here for projects containing thousands of files). The selection should always include also none to reset a previous choice.

Context

[this is the current modal, not a mockup]

Screenshot_20220407_080954

@rokroskar
Copy link
Member

Thanks @lorenzo-cavazzi for writing this up! I think the proposal makes sense. cc @volodymyrss

@ciyer ciyer added this to the 2.3.1-next-next milestone Jun 8, 2022
@ciyer ciyer moved this to Todo in UI Sprints - DEPRECATED Jun 8, 2022
@ciyer ciyer added the 2 label Jun 8, 2022
@andre-code andre-code moved this from Todo to In Progress in UI Sprints - DEPRECATED Jun 14, 2022
Repository owner moved this from In Progress to Done in UI Sprints - DEPRECATED Jun 21, 2022
ciyer pushed a commit that referenced this issue Aug 15, 2022
…autosave branch (#1947)

Undo a change that was introduced in #1781, which opens the wrong dialog.

Fix #1947
ciyer pushed a commit that referenced this issue Aug 15, 2022
…autosave branch (#1947)

Undo a change that was introduced in #1781, which opens the wrong dialog.

Fix #1947
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants