Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show the correct dialog when starting a session on an autosave branch #2000

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Aug 15, 2022

Undo a change that was introduced in #1781, which opens the wrong dialog.

Fix #1947

Test

To test, fork this project:

https://sekhar.dev.renku.ch/projects/cramakri/test-accessing-gpus

Then, in your fork, create a branch based on renku/autosave/cramakri/master/2f88472/2f88472 with the name renku/autosave/{your username}/master/2f88472/2f88472

/deploy #persist

…autosave branch (#1947)

Undo a change that was introduced in #1781, which opens the wrong dialog.

Fix #1947
@ciyer ciyer requested a review from a team as a code owner August 15, 2022 12:41
@ciyer ciyer deployed to renku-ci-ui-2000 August 15, 2022 12:42 Active
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-2000.dev.renku.ch

Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 🚀

@ciyer ciyer merged commit 162f28e into master Aug 15, 2022
@ciyer ciyer deleted the 1947-autosave-start branch August 15, 2022 14:29
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

@ciyer ciyer added this to the 2.7.0 milestone Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autosaves occasionally mess up with the "Start button" session
4 participants