Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ShapeUp] Search and Discovery 1.0 #3032

Merged
merged 11 commits into from
Mar 26, 2024
Merged

[ShapeUp] Search and Discovery 1.0 #3032

merged 11 commits into from
Mar 26, 2024

Conversation

lorenzo-cavazzi
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi commented Feb 13, 2024 •
edited by andre-code
Loading

Feature branch for Search and Discovery 1.0
Pitch: https://www.notion.so/Renku-1-0-Project-and-User-Search-Service-e3df82dab0734f91bb8dc128f5e3aa54
Build page: https://www.notion.so/Renku-1-0-Search-Discovery-Services-Build-Team-cc4782794e084adca8fe9c36571d7b99

/deploy renku=build/search-and-discovery-1.0 renku-data-services=main renku-gateway=master

@lorenzo-cavazzi lorenzo-cavazzi marked this pull request as draft February 13, 2024 13:52
@lorenzo-cavazzi lorenzo-cavazzi force-pushed the build/search-and-discovery-1.0 branch 3 times, most recently from 674129d to 4ba5f46 Compare February 19, 2024 08:19
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3032.dev.renku.ch

@andre-code andre-code marked this pull request as ready for review March 15, 2024 14:53
@andre-code andre-code requested a review from a team as a code owner March 15, 2024 14:53
@andre-code
Copy link
Contributor

andre-code commented Mar 15, 2024 •
edited
Loading

Items for review:

  • Searching by Query Type, Visibility, and Creation Date for authenticated users
    search

  • Search by Role

  • Searching by Query Type and Creation Date for non-authenticated users

  • Sorting by Score, Creation Date, and Name

  • Filtering by user ID
    search by user

leafty
leafty reviewed Mar 20, 2024
View reviewed changes
client/run-telepresence.sh Outdated Show resolved Hide resolved
leafty
leafty reviewed Mar 20, 2024
View reviewed changes
client/src/features/rootV2/NavbarV2.tsx Outdated Show resolved Hide resolved
client/src/features/rootV2/NavbarV2.tsx Outdated Show resolved Hide resolved
ciyer
ciyer requested changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks very good! 🚀 I have two minor change requests which should be easy to implement.

client/src/utils/helpers/url/Url.js Show resolved Hide resolved
client/src/features/searchV2/components/SearchV2Results.tsx Outdated Show resolved Hide resolved
@andre-code andre-code force-pushed the build/search-and-discovery-1.0 branch from 7ca80a4 to c44cc51 Compare March 21, 2024 13:08
@andre-code andre-code requested a review from ciyer March 22, 2024 09:15
ciyer
ciyer previously approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

lorenzo-cavazzi and others added 9 commits March 26, 2024 10:21
@lorenzo-cavazzi @andre-code
feat(client): add basic support for the new search 1.0 API (#3033)
89d8541
@lorenzo-cavazzi @andre-code
feat(client): adapt the frontend to the latest version of the search …
2ae569e 
…backend (#3054)

Includes updates to supported filtering and sorting methods
@lorenzo-cavazzi @andre-code
feat: add pagination and new filters (#3056)
00c604f 
feat: support pagination, refresh query automatically and add filters by creationDate and createdBy
Co-authored-by: Andrea Cordoba <dandrea.cordoba@gmail.com>
@andre-code
feat: clean new project form after submit and refresh project list wh…
71bc873 
…en create a new project (#3071)
@andre-code
update role query, fix index components, remove telepresence change
d22f785
@leafty @andre-code
fix merge in projectV2.enhanced-api.ts
5374a2c
@andre-code
update role query
86385c4
@andre-code
make role filters no checked by default
3695f07
@andre-code
fix conflict in EnhancedState.ts
eacd8c3
@andre-code andre-code force-pushed the build/search-and-discovery-1.0 branch from 7baa37b to eacd8c3 Compare March 26, 2024 09:29
ciyer
ciyer approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the new changes, and everything works for me! 🚀

@andre-code andre-code merged commit 302737f into main Mar 26, 2024
17 checks passed
@andre-code andre-code deleted the build/search-and-discovery-1.0 branch March 26, 2024 12:03
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andre-code andre-code andre-code left review comments

@leafty leafty leafty left review comments

@ciyer ciyer ciyer approved these changes

Assignees
No one assigned
Labels
ShapeUp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lorenzo-cavazzi @RenkuBot @andre-code @leafty @ciyer