-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build/clean v2 project form #3071
Build/clean v2 project form #3071
Conversation
You can access the deployment of this PR at https://renku-ci-ui-3071.dev.renku.ch |
8fc9c3d
to
9e102b7
Compare
9e102b7
to
7039d67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! 🚀
There was a weird error in the CI pipeline. I am re-running, I will approve once CI passes.
…ter create a new project
7039d67
to
786c743
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about a hook, otherwise seems good.
const dispatch = useDispatch(); | ||
useEffect(() => { | ||
dispatch(setCurrentStep(0)); | ||
}, []); // eslint-disable-line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not ignore the rules of hooks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added in the last commit
Tearing down the temporary RenkuLab deplyoment for this PR. |
…en create a new project (#3071)
* feat(client): add basic support for the new search 1.0 API (#3033) * feat(client): adapt the frontend to the latest version of the search backend (#3054) Includes updates to supported filtering and sorting methods * feat: add pagination and new filters (#3056) support pagination, refresh query automatically and add filters by creationDate and createdBy * feat: clean new project form after submit and refresh project list when create a new project (#3071) Co-authored-by: Andrea Cordoba <dandrea.cordoba@gmail.com>
This PR is about making improvements to the v2 new project form.
Changes:
/deploy #notest