Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/clean v2 project form #3071

Merged

Conversation

andre-code
Copy link
Contributor

@andre-code andre-code commented Mar 12, 2024

This PR is about making improvements to the v2 new project form.

Changes:

  • After successfully creating a new project, the form will be cleaned up.
  • When a new project is created, the project list will be refreshed automatically.
  • We're adding better btn styles, spacing, and icons to make the new project form easier to use.

/deploy #notest

@andre-code andre-code changed the base branch from main to build/search-and-discovery-1.0 March 12, 2024 16:21
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3071.dev.renku.ch

Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 🚀

There was a weird error in the CI pipeline. I am re-running, I will approve once CI passes.

Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about a hook, otherwise seems good.

const dispatch = useDispatch();
useEffect(() => {
dispatch(setCurrentStep(0));
}, []); // eslint-disable-line
Copy link
Member

@leafty leafty Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not ignore the rules of hooks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in the last commit

@andre-code andre-code merged commit 3683099 into build/search-and-discovery-1.0 Mar 14, 2024
12 checks passed
@andre-code andre-code deleted the build/clean-v2-project-form branch March 14, 2024 13:35
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

andre-code added a commit that referenced this pull request Mar 26, 2024
andre-code added a commit that referenced this pull request Mar 26, 2024
* feat(client): add basic support for the new search 1.0 API (#3033)

* feat(client): adapt the frontend to the latest version of the search backend (#3054)
Includes updates to supported filtering and sorting methods

* feat: add pagination and new filters  (#3056)
support pagination, refresh query automatically and add filters by creationDate and createdBy

* feat: clean new project form after submit and refresh project list when create a new project (#3071)

Co-authored-by: Andrea Cordoba <dandrea.cordoba@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants