Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design changes - 2nd round #3254

Merged
merged 18 commits into from
Sep 27, 2024
Merged

Design changes - 2nd round #3254

merged 18 commits into from
Sep 27, 2024

Conversation

lorenzo-cavazzi
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi commented Jul 25, 2024 •
edited
Loading

Feature branch for the 2nd round of design changes.

/deploy

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3254.dev.renku.ch

Base automatically changed from lorenzo/bootstrap-design to main July 30, 2024 09:05
@lorenzo-cavazzi @leafty
fix: use consistent navy colors for top navbar and bottom footbar (#3262
d141376 
)

Added a "navy" Bootstrap theme.

---------

Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
@lorenzo-cavazzi
refactor: change alerts (#3273)
9965ed0 
* Use the non-filled icons as in most v2 components.
* Inherit the color used for the alert to improve contrast.
* Avoid using text classes for the non-text icon.
@lorenzo-cavazzi @leafty
fix: prevent glitches on smaller screens (#3326)
6f2a9f6 
Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
@lorenzo-cavazzi lorenzo-cavazzi marked this pull request as ready for review September 26, 2024 07:29
@lorenzo-cavazzi lorenzo-cavazzi requested a review from a team as a code owner September 26, 2024 07:29
ciyer
ciyer approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@lorenzo-cavazzi lorenzo-cavazzi merged commit 26e9a21 into main Sep 27, 2024
18 checks passed
@lorenzo-cavazzi lorenzo-cavazzi deleted the lorenzo/design-2nd-round branch September 27, 2024 09:45
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciyer ciyer ciyer approved these changes

Assignees
No one assigned
Labels
ShapeUp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lorenzo-cavazzi @RenkuBot @ciyer