feat(notebooks): add polling to Jupyter button in notebook preview #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzo-cavazzi
force-pushed
the
559-polling-launchnotebook-button
branch
from
32723fe
to
0866d33
Compare
lorenzo-cavazzi
force-pushed
the
559-polling-launchnotebook-button
branch
from
0866d33
to
e992fe8
Compare
ciyer
approved these changes
Sep 6, 2019
There was a problem hiding this comment.
I like the way this works a lot. The gray/colored in jupyter icon is a nice touch. I have one question about a place where I see explicitly a reference to the "master" branch. Not sure if that is ok or needs to be changed in case the default branch is not master.
| if (this.props.accessLevel < ACCESS_LEVELS.MAINTAINER) | ||
| return (<CheckNotebookIcon fetched={true} launchNotebookUrl={this.props.launchNotebookUrl} />); | ||
|
|
||
| const scope = { |
There was a problem hiding this comment.
Is it appropriate to hardcode the master branch here?
|
As discussed, I'll handle this case in #597 by adopting a coherent solution (checking the existence of "master" and selecting another branch if not available) since it wouldn't make sense to ask the user to start a new environment and then not being able to detect it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LaunchJupytercomponent has been superseded byJupyterButton. It gives more detailed feedback on the current interactive environment status and it keeps the information updated by polling the/serversAPI.This implied a few changes:
Fileto new ones inNotebooksJupyterIconcomponent -- the svg icon may be handled differently (http://tiny.cc/i4p7bz) but that requires changing the SVG code to properly handle greyscale with thefillproperty. The current approach is close to what we do withreact-fontawesome, so it should look familiar.Preview available here: https://lorenzotest.dev.renku.ch
How to test: open any notebook files from the
Filetab of a project and try to click on the Jupyter icon on the top right.E.G. https://lorenzotest.dev.renku.ch/projects/lorenzo.cavazzi.tech/zurich-bikes-tutorial/files/blob/notebooks/zhbikes-notebook.ipynb
fix #559