feat(notebooks): handle non-standard branches projects #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
P.S. tests will fail, I will fix them after #582 is merged since that should already address the problem |
ciyer
previously approved these changes
Sep 6, 2019
lorenzo-cavazzi
force-pushed
the
595-notify-no-commits
branch
from
dc7c233
to
a9e0a4c
Compare
|
I added the code to handle projects without "master" branch also for the "Launch Jupyter" button in the File preview notebooks. This completes the PR by handling also the new component introduced in #582. An updated preview is available at https://lorenzotest.dev.renku.ch |
these 2 cases are now handled: * the project doesn't contain a branch named "master": another branch is selected -- if available * the project doesn't contain any commit: the user is notified and guided through possible steps fix #595
lorenzo-cavazzi
force-pushed
the
595-notify-no-commits
branch
from
a9e0a4c
to
e81481c
Compare
ciyer
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI showed wrong feedback when trying to start a new interactive environment for projects without a
masterbranch or without any branch/commit at all (note that 1 branch requires at least 1 commit, and also the other way around is also true).This PR handles the 2 cases as follows:
How to test:
originfix #595