Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update name for GAP in CellfieConsensus metabolic tasks #696

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

exaexa
Copy link
Contributor

@exaexa exaexa commented Aug 29, 2023

This is a simple fix that follows the previous commits (https://github.com/exaexa/Human-GEM/commit/8182ade485807697c2e79cf12b2a89f91e5f20cb) to remove old name for GAP[c].

@exaexa
Copy link
Contributor Author

exaexa commented Aug 29, 2023

Extra comment: I can't find the other "missing" metabolite, NA[c]. Is there any way how to find these metabolites systematically?

@mihai-sysbio
Copy link
Member

mihai-sysbio commented Aug 29, 2023

This is a simple fix that follows the previous commits (exaexa@8182ade) to remove old name for GAP[c].

Thanks @exaexa. I think I've seen this recently 🤔

Update: here and here

@exaexa
Copy link
Contributor Author

exaexa commented Aug 29, 2023

(cc @migp11 )

@haowang-bioinfo haowang-bioinfo merged commit 5bade46 into SysBioChalmers:develop Aug 29, 2023
4 checks passed
@exaexa exaexa deleted the mk-fix-gap branch August 29, 2023 14:20
@exaexa
Copy link
Contributor Author

exaexa commented Aug 30, 2023

@haowang-bioinfo @mihai-sysbio is there please any info on the NA[c] metabolite? ref:

37 Glycogen biosynthesis NA[c] 1 1 glycogenin G4G7[c] 1 1
(and several other places)

@JonathanRob
Copy link
Collaborator

@exaexa these metabolic tasks were imported/translated from their source at Cellfie, seemingly from CONSENSUS_TASKS.xls.

I checked the corresponding task in this original source file, and it looks like the NA[c] metabolite should be Tyr_ggn[c]. It is unclear to me what metabolite this should correspond to in Human-GEM - maybe glycogenin[c]?

@exaexa
Copy link
Contributor Author

exaexa commented Aug 30, 2023

Thanks a lot! I'll have a look asap and hopefully send another PR today

@migp11
Copy link

migp11 commented Aug 30, 2023

Hi,

I've been checking for Tyr_ggn_e in BiGG and it says that this metabolite is Tyr-194 of apo-glycogenin protein (primer for glycogen synthesis). Furthermore, The same cross-reference is found in VHM.

Then I followed the cross-reference to MetaNetX through the identifier MNXM146651 and it seems this ID is deprecated and replaced by MNXM728887.

The strange thing is that in MetaNetX MNXM728887 corresponds to Thyroglobulin L-tyrosine and after a quick search I found that Thyroglobulin is not involved in glycogen metabolism but instead, Thyroglobulin is a 660 kDa, dimeric glycoprotein produced by the follicular cells of the thyroid and used entirely within the thyroid gland [reference].

Therefore, my conclusion is that the cross-reference to MetNetX is wrong. Tyr_ggn is "Tyr-194 Of Apo-Glycogenin Protein" the glycoprotein involved in glycogen biosynthesis.

Finally, I checked reactions in Recon3D (VHM) for this metabolite and the only relevant (not an exchange/source/sink) is the following:

GLPASE2
Glycogen Phosphorylase (Amyls -> Glc-D)
glygn3[c] + 7.0 h2o[c] -> 7.0 glc_D[c] + Tyr_ggn[c]

and although it is cross-referenced to MetaNetX through (MNXR100266) I was not able to find the corresponding reactions in HumanGEM. Thus, to avoid other users running into the same issue, this task should be marked as conflicting with HumanGEM or some kind of warning.

My two cents!
Best
Miguel

@haowang-bioinfo
Copy link
Member

haowang-bioinfo commented Aug 30, 2023

@migp11 such a nice and comprehensive investigation!

totally agree that this task need to be disabled, or at least warned while checking.

@exaexa
Copy link
Contributor Author

exaexa commented Aug 30, 2023

@migp11 oh whoops I missed your investigation before I started #697... can you pls check if the fix makes sense at least partially there? :]

@haowang-bioinfo
Copy link
Member

one probable solution is set feature SHOULD FAIL of this row to "TRUE", and mark in COMMENTS column that: "This task is conflicting with HumanGEM"

@migp11
Copy link

migp11 commented Aug 30, 2023

@haowang-bioinfo, your suggestion might be a good workaround, or not, depending on how missing/unknown metabolites are treated when a task is created. If unknown metabolites are ignored then, it is possible that the task would be feasible (though biochemically inconsistent). On the other hand, if an error is raised when an unknown metabolite is found on a task, then it is clear that the task should not be used.

@migp11
Copy link

migp11 commented Aug 30, 2023

One last though, seen NA[c] for several different metabolites makes me think that NA might mean "Not Available" and it is added whenever a metabolite in a task is not present in the model

@JonathanRob
Copy link
Collaborator

one probable solution is set feature SHOULD FAIL of this row to "TRUE", and mark in COMMENTS column that: "This task is conflicting with HumanGEM"

I'm hesitant to use this solution, since if at some point in the future the model is able to pass the task, then it will be penalized for not failing that task (in the likely scenario that we forget to change the task file back again).

I believe one can "comment-out" rows in the task file by adding a # in the first column. So a solution could be to comment-out the rows corresponding to the problematic task, while also adding a comment as @haowang-bioinfo suggests. But I haven't tested adding a # since we changed the task file format from .xlsx to .tsv, so I'm not sure if it will work.

@mihai-sysbio
Copy link
Member

Pitching in as well, I wouldn't mind seeing the link to this issue in the COMMENTS field.

@haowang-bioinfo
Copy link
Member

haowang-bioinfo commented Sep 19, 2023

I believe one can "comment-out" rows in the task file by adding a # in the first column. So a solution could be to comment-out the rows corresponding to the problematic task, while also adding a comment as @haowang-bioinfo suggests. But I haven't tested adding a # since we changed the task file format from .xlsx to .tsv, so I'm not sure if it will work.

adding hash tag seems to be a good option, and works well by testing with the latest .tsv file

One last though, seen NA[c] for several different metabolites makes me think that NA might mean "Not Available" and it is added whenever a metabolite in a task is not present in the model

indeed, multiple occurrence of NA[c] can be observed, such as in tasks number 37, 38, and 181. No sure if NA[c] represents "Not Available", could it be something like a place holder?

@haowang-bioinfo
Copy link
Member

haowang-bioinfo commented Sep 22, 2023

indeed, multiple occurrence of NA[c] can be observed, such as in tasks number 37, 38, and 181. No sure if NA[c] represents "Not Available", could it be something like a place holder?

to move #697 forward, would lean toward adding hash tag to comment-out tasks 37, 38, and 181, and with comments: "The metabolite NA[c] in this task is conflicting with HumanGEM"

@haowang-bioinfo haowang-bioinfo mentioned this pull request Sep 25, 2023
@haowang-bioinfo haowang-bioinfo mentioned this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants