Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zero-growth in anaerobic conditions #198

Closed
4 tasks done
BenjaSanchez opened this issue Aug 28, 2019 · 7 comments · Fixed by #213
Closed
4 tasks done

fix: zero-growth in anaerobic conditions #198

BenjaSanchez opened this issue Aug 28, 2019 · 7 comments · Fixed by #213
Assignees
Labels
bug something is wrong in the model fixed in devel this issue is already fixed in devel and will be closed after the next release

Comments

@BenjaSanchez
Copy link
Contributor

Description of the issue:

The model is currently not able to grow anaerobically, which is most likely due to the inclusion of several cofactors to the biomass composition (PR #174). We should find which cofactors are the culprit and adapt the function anaerobicModel.m to omit those cofactors, as it is already done with heme a.

Reproducing these results:

model = loadYeastModel;
anaerobicModel
sol = optimizeCbModel(model);

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Done this analysis in the master branch of the repository
  • Checked that a similar issue does not exist already
  • If needed, asked first in the Gitter chat room about the issue
@BenjaSanchez BenjaSanchez added bug something is wrong in the model help wanted feel free to help us solving this issue! labels Aug 28, 2019
@feiranl
Copy link
Collaborator

feiranl commented Aug 28, 2019

Yes, this problem is due to that we adding cofactors in the model. We addressed the problem locally before, and will be uploaded soon.

@BenjaSanchez BenjaSanchez added wip work in progress and removed help wanted feel free to help us solving this issue! labels Aug 30, 2019
@BenjaSanchez
Copy link
Contributor Author

@feiranl any progress here? in the meantime could you indicate here which cofactors are the responsibles for no growth, so to inform people that may wish to use the model anaerobically?

@BenjaSanchez BenjaSanchez added fixed in devel this issue is already fixed in devel and will be closed after the next release and removed wip work in progress labels Nov 11, 2019
@BenjaSanchez
Copy link
Contributor Author

update: this has been fixed in #199 by removing NAD, NADP, NADPH and NADH from the biomass equation for anaerobic conditions. This issue will be closed on the next release

@feiranl
Copy link
Collaborator

feiranl commented Apr 28, 2020

We identified that coenzyme A also requires oxygen due to oxygen requirement of precursor beta-alanine. However, due to missing coA in the reactionr_4571 2-hydroxyglutarate [cytoplasm] <=> glyoxylate [cytoplasm] + 3 H+ [cytoplasm] + propionyl-CoA [cytoplasm] and it will generate coA unlimitedly. We should remove coA also from the anaerobic growth. Thanks Eiden @eiden309 for pointing out the missing coA in the reaction r_4571. Will be fixed in the future.

@BenjaSanchez
Copy link
Contributor Author

@feiranl the bigger issue then would be to solve the CoA balancing of that reaction though, could you open an issue for that?

@edkerk
Copy link
Member

edkerk commented Apr 28, 2020

@feiranl the bigger issue then would be to solve the CoA balancing of that reaction though, could you open an issue for that?

This is being done by @eiden309 as part of #194, should be committed to GitHub soon.

@feiranl
Copy link
Collaborator

feiranl commented Apr 28, 2020

Yes, it will be balanced in the #194.

eiden309 added a commit that referenced this issue May 16, 2020
Add model.metNotes and model.rxnNotes with correct annotation PR #220 instead of PR #198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is wrong in the model fixed in devel this issue is already fixed in devel and will be closed after the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants