Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/improvedReadme #123

Merged
merged 4 commits into from
Jun 18, 2018
Merged

Feat/improvedReadme #123

merged 4 commits into from
Jun 18, 2018

Conversation

BenjaSanchez
Copy link
Contributor

Main improvements in this PR:

  • README.md updates automatically when saving the model (date + model size). Date won't update in new releases (or when desired by the upDATE flag).
  • Various fixes in README.md.
  • Added contributor.

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Selected devel as a target branch (top left drop-down menu)
  • If needed, asked first in the Gitter chat room about this PR

corrected links + added contributor
date + model size is now updated when using saveYeastModel.m
to avoid eventual conflicts between master and devel (review of PR might take more a day or more)
@BenjaSanchez BenjaSanchez added the format fix things associated to format of any of the model/data/script files label Jun 10, 2018
@BenjaSanchez
Copy link
Contributor Author

@edkerk maybe the automatic update of README.md can be included in exportForGit?

@edkerk
Copy link
Member

edkerk commented Jun 11, 2018

@BenjaSanchez good point!

@feiranl
Copy link
Collaborator

feiranl commented Jun 18, 2018 via email

@BenjaSanchez
Copy link
Contributor Author

BenjaSanchez commented Jun 18, 2018

@feiranl looks like your dependencies (in this case RAVEN) are out of date https://github.com/SysBioChalmers/yeast-GEM

Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is functional in MAC

@BenjaSanchez BenjaSanchez merged commit 8bf683c into devel Jun 18, 2018
@BenjaSanchez BenjaSanchez deleted the feat/improvedReadme branch June 21, 2018 08:44
@BenjaSanchez BenjaSanchez mentioned this pull request Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format fix things associated to format of any of the model/data/script files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants