Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/modelParams #127

Merged
merged 2 commits into from
Jun 27, 2018
Merged

Feat/modelParams #127

merged 2 commits into from
Jun 27, 2018

Conversation

BenjaSanchez
Copy link
Contributor

Main improvements in this PR:

modelID and modelName are now added as COBRA fields.

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Selected devel as a target branch (top left drop-down menu)
  • If needed, asked first in the Gitter chat room about this PR

@BenjaSanchez
feat: model parameters
0a013e3 
* model.modelID: short name
* model.modelName: full name
@BenjaSanchez
fix: increaseVersion
2828ecd 
version is now stored in id, not metaid.
@BenjaSanchez BenjaSanchez added the enhancement new field/feature label Jun 26, 2018
@BenjaSanchez BenjaSanchez self-assigned this Jun 26, 2018
@BenjaSanchez BenjaSanchez merged commit 736ea61 into devel Jun 27, 2018
@BenjaSanchez BenjaSanchez mentioned this pull request Jun 27, 2018
Merged
@BenjaSanchez BenjaSanchez deleted the feat/modelParams branch July 7, 2018 10:48
@BenjaSanchez BenjaSanchez restored the feat/modelParams branch July 7, 2018 10:48
@BenjaSanchez BenjaSanchez deleted the feat/modelParams branch July 7, 2018 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongzhonglu hongzhonglu hongzhonglu approved these changes

Assignees

@BenjaSanchez BenjaSanchez

Labels
enhancement new field/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenjaSanchez @hongzhonglu