fix: non-compliant symbol #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"malate/β-methylmalate synthase", introduced in PR #156, creates parsing errors -> now it's stored as "malate/beta-methylmalate synthase"
BenjaSanchez
added
format fix
|
@BenjaSanchez would be good to archive such type of bug publicly so that all other GEM repos can learn and avoid this. |
hongzhonglu
approved these changes
Nov 30, 2018
feiranl
approved these changes
Nov 30, 2018
|
@hongzhonglu good idea, will include it in the contribution guidelines when we draft "model conventions" |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
As recently discussed, "malate/β-methylmalate synthase", introduced in PR #156, creates parsing errors -> now it's stored as "malate/beta-methylmalate synthase"
I hereby confirm that I have:
develas a target branch (top left drop-down menu)