Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/biomasSBOterms #180

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Fix/biomasSBOterms #180

merged 1 commit into from
Nov 30, 2018

Conversation

BenjaSanchez
Copy link
Contributor

Main improvements in this PR:

PR #174 included cofactor & ion pseudo-metabolites, so addSBOterms.m is now modified accordingly.

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Selected devel as a target branch (top left drop-down menu)
  • If needed, asked first in the Gitter chat room about this PR

PR #174 included "cofactor" & "ion" pseudo-metabolites, so addSBOterms.m should be modified accordingly
@BenjaSanchez BenjaSanchez added the bug something is wrong in the model label Nov 26, 2018
@BenjaSanchez BenjaSanchez self-assigned this Nov 26, 2018
@BenjaSanchez BenjaSanchez changed the title Fix/biomassoterms Fix/biomasSBOterms Nov 26, 2018
Copy link
Collaborator

@hongzhonglu hongzhonglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@BenjaSanchez BenjaSanchez merged commit 2339f00 into devel Nov 30, 2018
@BenjaSanchez BenjaSanchez mentioned this pull request Dec 4, 2018
@BenjaSanchez BenjaSanchez deleted the fix/biomassSBOterms branch December 7, 2018 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is wrong in the model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants