Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-rxn.prop: Hydrogen Sulfide Addition #300

Merged
merged 27 commits into from
May 6, 2022

Conversation

wtscott31
Copy link
Contributor

This is an enhancement to the model to properly account for the pathways responsible for the formation of hydrogen sulfide as well as other volatile sulfur compounds during fermentation (see source:https://academic.oup.com/femsyr/article/17/6/fox058/4056150)

Main improvements in this PR:

Try to be as clear as possible: Is it fixing/adding something in the model? Is it an additional test/function/dataset? PLEASE DELETE THIS LINE.

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Selected develop as a target branch (top left drop-down menu)
  • If needed, asked first in the Gitter chat room about this PR

edkerk and others added 2 commits December 17, 2021 15:25
This is an enhancement to the model to properly account for the pathways responsible for the formation of hydrogen sulfide as well as other volatile sulfur compounds during fermentation (see source:https://academic.oup.com/femsyr/article/17/6/fox058/4056150)
@wtscott31 wtscott31 linked an issue Mar 9, 2022 that may be closed by this pull request
4 tasks
@edkerk edkerk self-assigned this Mar 9, 2022
@edkerk edkerk self-requested a review March 9, 2022 10:06
@edkerk edkerk changed the base branch from main to develop March 9, 2022 22:38
@edkerk edkerk force-pushed the 296-feat-volatiles-produced-by-s.-cerevisiae branch from ed68231 to 031c9ce Compare March 13, 2022 23:14
@edkerk
Copy link
Member

edkerk commented Mar 13, 2022

Reviewing this PR, I realized that we did not have an intuitive and straightforward way to make such curations. To fix this, not just for here, but also for future usage, I wrote a function code/curateMetsRxnsGenes() that can take standardized TSV files as input, and adds the required metabolites, genes and/or reactions, with various warnings and error messages if something is going wrong. See the updated code/modelCuration/addSULnewRxn.m to see how this is run, and notice that the TSV files have some minor changes. This curateMetsRxnsGenes() will likely be incorporated in RAVEN in the near future, but for now is distributed with yeast-GEM.

Then, down to the actual model changes:

  • There were three transport reactions (cytoplasm <=> extracellular) that were called "exchange", this was corrected.
  • Three real exchange reactions were added, at the moment only allowing excretion.
  • If you make a new branch for curating the model, make sure you branch it from the devel branch, not the main branch!

To do (@wtscott31) :

  • The gene YOL164W is included, but should probably also be assigned to a particular reaction. If it is not used in any reaction, there is no need to add it to the model.

Note: the model was exported by using the branch from PR #301 and RAVEN from branch PR #396. Due to various generic model changes (identifiers suffices, sorting of entities etc.), it looks there were massive changes in the model files. Commit 031c9ce is the best representative of real model changes related to sulfur metabolism.

@wtscott31
Copy link
Contributor Author

wtscott31 commented Mar 14, 2022 via email

@edkerk
Copy link
Member

edkerk commented Mar 14, 2022

Ok, because also in the article that you cite it shows BDS1 as involved in sulfate ester -> sulfate (Fig 1). But are none of the reactions that you propose to add an example of such a reaction?

@wtscott31
Copy link
Contributor Author

wtscott31 commented Mar 14, 2022 via email

- update software requirements
- layout tweaks
- include version number, unless it is develop branch
- get previous version number from version.txt
- support to edit the modified model stats in README.md
- remove unnecessary code (e.g. boundaryMets are never used, no point in tracking it each time, can otherwise be easily reconstituted for the rare uses cases)
…t-volatiles-produced-by-s.-cerevisiae

# Conflicts:
#	README.md
#	model/boundaryMets.txt
#	model/yeast-GEM.txt
#	model/yeast-GEM.xml
#	model/yeast-GEM.yml
@edkerk
Copy link
Member

edkerk commented Mar 26, 2022

With commit bbcc58f:

With commit ef8eaf6:

  • Added a few additional metabolite identifiers (MetaNetX, BiGG, BioCyc).
  • Curated existing hydrogen sulfide metabolites for consistent identifiers.
  • Renamed 2-oxo-3-sulfanylpropanoate to more recognizable 3-mercaptopyruvate.

Remaining issues (@wtscott31):

  • The 3-mercaptopyruvate sulfurtransferase should be corrected. I noticed that dihydrolipoate disulfide (DHLA) was annotated with the KEGG ID for thioredoxin disulfide. Inspecting the cited reference, it seems to refer to Mikami et al. 2011, which suggests that both DHLA and thioredoxin are required in mice. Thioredoxin is currently not part of the 3-mercaptopyruvate sulfurtransferase reaction. Should DHLA (and dihydrolipoate disulfide) be replaced with oxidized & reduced thioredoxin?
  • If DHLA should be kept in the reaction above, it does not seems to be recycled: it should also be produced in another reaction, otherwise this pathway is blocked.
  • Related to that, there does not seem to be a purpose for the dihydrolipoate-diphosphate reaction: it produces dihydrolipoyl-AMP that is not consumed elsewhere. Considering that this is a reaction without gene association, it should be left out.

@wtscott31
Copy link
Contributor Author

With commit bbcc58f:

With commit ef8eaf6:

  • Added a few additional metabolite identifiers (MetaNetX, BiGG, BioCyc).
  • Curated existing hydrogen sulfide metabolites for consistent identifiers.
  • Renamed 2-oxo-3-sulfanylpropanoate to more recognizable 3-mercaptopyruvate.

Remaining issues (@wtscott31):

  • The 3-mercaptopyruvate sulfurtransferase should be corrected. I noticed that dihydrolipoate disulfide (DHLA) was annotated with the KEGG ID for thioredoxin disulfide. Inspecting the cited reference, it seems to refer to Mikami et al. 2011, which suggests that both DHLA and thioredoxin are required in mice. Thioredoxin is currently not part of the 3-mercaptopyruvate sulfurtransferase reaction. Should DHLA (and dihydrolipoate disulfide) be replaced with oxidized & reduced thioredoxin?

If you look at the reference Huang et al. 2017, Fig. 1 ((https://academic.oup.com/femsyr/article/17/6/fox058/4056150) TUM1 gene associated reaction is a required part of sulphur metabolism. It is also cited here:(https://pathway.yeastgenome.org/YEAST/NEW-IMAGE?object=TUM1). I think we should include (1b) [3-mercaptopyruvate sulfurtransferase]-S-sulfanyl-L-cysteine + reduced thioredoxin = hydrogen sulfide + [3-mercaptopyruvate sulfurtransferase]-L-cysteine + oxidized thioredoxin [RN:R12690] for 3-mercaptopyruvate sulfurtransferase instead of the current one.

  • If DHLA should be kept in the reaction above, it does not seems to be recycled: it should also be produced in another reaction, otherwise this pathway is blocked.

See answer above.

  • Related to that, there does not seem to be a purpose for the dihydrolipoate-diphosphate reaction: it produces dihydrolipoyl-AMP that is not consumed elsewhere. Considering that this is a reaction without gene association, it should be left out.

Yes, it should be left out. See answer above.

@edkerk
Copy link
Member

edkerk commented May 6, 2022

I think we should include (1b) [3-mercaptopyruvate sulfurtransferase]-S-sulfanyl-L-cysteine + reduced thioredoxin = hydrogen sulfide + [3-mercaptopyruvate sulfurtransferase]-L-cysteine + oxidized thioredoxin [RN:R12690] for 3-mercaptopyruvate sulfurtransferase instead of the current one.

That would only be a half-reaction, where the [3-mercatopyruvate sulfurtransferase]- metabolite is the actual gene associated to this reaction. Instead I've now included the whole reaction: TRX1 + 3-mercaptopyruvate --> TRX1 disulphide + pyruvate + hydrogen sulfide.

@wtscott31
Copy link
Contributor Author

I think that reaction should be acceptable then.

@edkerk edkerk merged commit 3c6c1b5 into develop May 6, 2022
@edkerk edkerk deleted the 296-feat-volatiles-produced-by-s.-cerevisiae branch May 6, 2022 14:23
@edkerk edkerk linked an issue May 9, 2022 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: function for reproducible and convenient model curation feat: volatiles produced by S. cerevisiae
2 participants