Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curation/metabolites #74

Merged
merged 33 commits into from
Mar 19, 2018
Merged

Curation/metabolites #74

merged 33 commits into from
Mar 19, 2018

Conversation

hongzhonglu
Copy link
Collaborator

@BenjaSanchez @feiranl
The metabolite name, charges, keggID and chebi ID were updated.
When save the model, the errors occured:
Undefined function or variable 'git'.
Error in saveYeastModel (line 37)
COBRAcommit = git('log -n 1 --format=%H');

Can you look into it? Great thanks!

hongzhonglu added 5 commits March 11, 2018 14:45
The metabolite annotation, including the detailed name, charge, keggID and chebiID was updated based on the latest chebi and kegg databases.

When save the model, the errors occured:
Undefined function or variable 'git'.
Error in saveYeastModel (line 37)
COBRAcommit = git('log -n 1 --format=%H');
Correct some errors and further update the metabolite name information in the model
The duplicated subsystems have been removed. Also the subsystem information is further corrected based on the previous model and kegg database
Remove the metabolite annotation infomation in mat format
@BenjaSanchez
Copy link
Contributor

BenjaSanchez commented Mar 14, 2018

@hongzhonglu thanks for the PR. Some changes to address:

  • The text files (metabolite.txt and yeast_uique_metabolites information with correction comment.txt) should have , as separator instead of ; for proper visualization.
  • Consider using shorter names for text files (yeast_uique_metabolites information with correction comment.txt is a bit too long)
  • The ComplementaryData folder should move up one level, to be at the same level as complementaryScripts
  • Any specific reason why the metabolite iron changed to include the charge (iron(2+))?

Regarding the error you mention, make sure that you have the Git wrapper added to your path

@hongzhonglu
Copy link
Collaborator Author

@BenjaSanchez I have tried to change the txt format, but not solve it, it may due to mac system. Can you help me change the txt format into the csv separated by comma? Thanks in advance!

@BenjaSanchez
Copy link
Contributor

@hongzhonglu I did it for metabolite.txt (b3e6b75), but couldn't for yeast_uique_metabolites information with correction comment.txt, as the file is way too big and gets clipped in my Excel. What are exactly the differences between both files? Any way that you could shorten a bit the second file?

@hongzhonglu
Copy link
Collaborator Author

@BenjaSanchez yeast_uique_metabolites information with correction comment.txt is just similar to metabolite.txt. So we can remove "yeast_uique_metabolites information with correction comment.txt".

BenjaSanchez and others added 10 commits March 16, 2018 17:08
all changes from devel applied to model
from metabolite_manual_curation.tsv
from metabolite_manual_curation.tsv
from metabolite_manual_curation.tsv
from metabolite_manual_curation.tsv
…te annotation

The remark information has been refined for each update of metabolite annoation to make the results more clear.
mostly mispells or redundant info
@BenjaSanchez BenjaSanchez merged commit 0f1ae14 into devel Mar 19, 2018
This was referenced Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants