-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin for rapid generation of staff pages - update UI & UX #269
Add plugin for rapid generation of staff pages - update UI & UX #269
Conversation
BREAKING CHANGE: The "articles" are not shown, but at least page loads.
…ff-page-plugin--ui-and-ux-updates
I hope this restores WYSIWYG.
I hope this prevents migrations.
…ff-page-plugin--ui-and-ux-updates
…-name' into task/TUP-125--staff-page-plugin--ui-and-ux-updates
i.e. let all other fields `blank=True`
…-name' into task/TUP-125--staff-page-plugin--require-only-certain-fields
…ields' into task/TUP-125--staff-page-plugin--ui-and-ux-updates
Not necessary now, because no algorithm needed.
…ff-page-plugin--ui-and-ux-updates
Accodign to H.P.: This field is only necessary for leadership, which are created manually. It's overkill for most staff.
- rename s-staff-profile to c-staff-profile - load c-staff-profile css from plugin instead - add staff_profile js in plugin - load staff_profile js from plugin
Warning: Image is only moved once. Image is not found after move. Error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave notes for reviewers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? To create "Staff profile plugins" in /admin
interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? To title /admin
page under "TACC STAFF PROFILES" (rather than "STAFF_PROFILE"),
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What? Consistent (and translatable) plugin identification. Use custom form layout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What? Set which fields are required. Add help text and custom labels. Define custom form layout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Help! Git got confused or I screwed up.
* Add plugin for rapid generation of staff pages * Add plugin for rapid generation of staff pages - split name into first and last (#294) * feat: split name into first and last name * fix: reduce first and last name to 110 chars * fix: replace template name w/ first_… and last_… * Add plugin for rapid generation of staff pages - update UI & UX (#269) * feat(tup-cms)!: save progress of ui/ux updates BREAKING CHANGE: The "articles" are not shown, but at least page loads. * style(tup-cms): missing html end tag slash * chore: rm .vscode/settings.json * fix: restore forms.py (untested) I hope this restores WYSIWYG. * fix: restore models.py changes (untested) I hope this prevents migrations. * fix: restore forms.py load * fix: articles not rendering (mismatched key) * fix: main col for articles with large content * feat: split name into first and last name * fix: reduce first and last name to 110 chars * fix: only require names, title, and email i.e. let all other fields `blank=True` * Add plugin for rapid generation of staff pages - require only certain fields (#295) * feat: add title2 (2nd, equal, optional job title) * fix: replace template name w/ first_… and last_… * feat: add post_nomial * fix: remove templatetag (overkill) Not necessary now, because no algorithm needed. * fix: markup should match live pages * refactor: move all ui context work into template * chore: remvoe superfluous edits of original code * feat: form layout and field labels * fix: cms_plugins name translate and single quotes * feat: add help_text * fix: remove verbose name for most wysiwig fields * fix: remove "Phone number" verbose name * fix: rename post_nomial to post_nomials * chore: migrations * refactor: no form ui in models, rename a field * refactor: do not use blank in models.py * docs: encourage photo and bio * fix: do not require photo * fix: markup conditionals * refactor: squash migrations * feat: help text for secondary job title * chore: migration reducing name field lengths * feat: remove "experience" field Accodign to H.P.: This field is only necessary for leadership, which are created manually. It's overkill for most staff. * feat: s-staff-profile.css * feat: at content wrap, undo c-content-block styles * docs: ntoe why s-staff-profile is global css * refactor: staff_profile css and js —⚠️ untested - rename s-staff-profile to c-staff-profile - load c-staff-profile css from plugin instead - add staff_profile js in plugin - load staff_profile js from plugin * fix: load staff_profile css * fix: bugs in staff_profile js —⚠️ incomplete Warning: Image is only moved once. Image is not found after move. Error. * fix: bugs in staff_profile js — ✓ complete * fix: move image ot after job title, not just name * feat: use ut seal if no staff photo * style: captialization in css comments * style: consistency in css comments * feat: model access via admin interface * style: nx format:write * chore: remove excess property on admin class * docs: in css comment warn about coupled html & css * fix: donot require photo field * feat: to load staff profile css+js on manual page * refactor: c-staff-profile → s-staff-profile * docs: remove inaccurate comment * docs: remove excess comment * docs: asset comment cleanup * fix: remove experience from forms and output * chore: move 'education" to bottom of form * feat: less margin beneath `<h3>` * docs: label blocks of css with different goals * docs: group css that actuall has the same goal * docs: title case css grouping comment * Add plugin for rapid generation of staff pages - more design tweaks (#300) * Add plugin for rapid generation of staff pages - manually squash migrations (#304) * docs: add staff_profile/README to log known issues * chore: nx format:write --------- Co-authored-by: Jake Rosenberg <jrosenberg@MacBook-Pro.lan> Co-authored-by: Wesley B <62723358+wesleyboar@users.noreply.github.com> Co-authored-by: Wesley Bomar <wbomar@tacc.utexas.edu>
Overview
Improve UI and UX and data.
Related
Changes
post_nomials
andtitle2
photo
to not be requiredexperience
1Testing
Setup
After TACC/tup-ui:README.md step 7, continue with TACC/Core-CMS/:README.md "Start Project" step 2.
docker exec -it tup_cms /bin/bash
then
python manage.py migrate staff_profile
Unless you already ran
python manage.py migrate
cuz you set up fresh local env on this branch.Verify job title and dept. combinations render as expected.
Verify image "alt text" possibilities:
alt
attr.alt
attr.Verify fields that are not required, when not provided, do not render excess markup.
<br /><small></small>
<div content-block">…</div>
Verify required fields are only names, title, and e-mail.
Any field required that is not filled will render error upon form submission.
Verify a missing photo will render the UT Seal.
Verify a missing photo will render the UT Seal.
Any required field left empty will cause error to render after form submission.
Verify design is responsive in specific ways:
Verify staff profiles can be browsed and edited via admin interface.
Either, open http://localhost:8000/admin/staff_profile/staffprofileplugin.
Or, from http://localhost:8000/admin/, scroll to "TACC Staff Profiles" and click "Staff profile plugins".
UI
Job Title & Dept. Differences
and 6. Photo Not Required & Fallback
image.not.required.and.has.fallback.mov
Responsive Design
Admin Interface
Notes
CMD Proposals - Staff Profile Layout & Data
Footnotes
H.P. says Professional Experience is for leadership, as wanted; rare in general; and easily appended to staff Bio. ↩