Add plugin for rapid generation of staff pages - more design tweaks #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
changed the base branch from
main
to
task/TUP-125--staff-page-plugin
wesleyboar
changed the title
wesleyboar
deleted the
task/TUP-125--staff-page-plugin--more-design-tweaks
branch
jarosenb
added a commit
that referenced
this pull request
Aug 28, 2023
* Add plugin for rapid generation of staff pages * Add plugin for rapid generation of staff pages - split name into first and last (#294) * feat: split name into first and last name * fix: reduce first and last name to 110 chars * fix: replace template name w/ first_… and last_… * Add plugin for rapid generation of staff pages - update UI & UX (#269) * feat(tup-cms)!: save progress of ui/ux updates BREAKING CHANGE: The "articles" are not shown, but at least page loads. * style(tup-cms): missing html end tag slash * chore: rm .vscode/settings.json * fix: restore forms.py (untested) I hope this restores WYSIWYG. * fix: restore models.py changes (untested) I hope this prevents migrations. * fix: restore forms.py load * fix: articles not rendering (mismatched key) * fix: main col for articles with large content * feat: split name into first and last name * fix: reduce first and last name to 110 chars * fix: only require names, title, and email i.e. let all other fields `blank=True` * Add plugin for rapid generation of staff pages - require only certain fields (#295) * feat: add title2 (2nd, equal, optional job title) * fix: replace template name w/ first_… and last_… * feat: add post_nomial * fix: remove templatetag (overkill) Not necessary now, because no algorithm needed. * fix: markup should match live pages * refactor: move all ui context work into template * chore: remvoe superfluous edits of original code * feat: form layout and field labels * fix: cms_plugins name translate and single quotes * feat: add help_text * fix: remove verbose name for most wysiwig fields * fix: remove "Phone number" verbose name * fix: rename post_nomial to post_nomials * chore: migrations * refactor: no form ui in models, rename a field * refactor: do not use blank in models.py * docs: encourage photo and bio * fix: do not require photo * fix: markup conditionals * refactor: squash migrations * feat: help text for secondary job title * chore: migration reducing name field lengths * feat: remove "experience" field Accodign to H.P.: This field is only necessary for leadership, which are created manually. It's overkill for most staff. * feat: s-staff-profile.css * feat: at content wrap, undo c-content-block styles * docs: ntoe why s-staff-profile is global css * refactor: staff_profile css and js —⚠️ untested - rename s-staff-profile to c-staff-profile - load c-staff-profile css from plugin instead - add staff_profile js in plugin - load staff_profile js from plugin * fix: load staff_profile css * fix: bugs in staff_profile js —⚠️ incomplete Warning: Image is only moved once. Image is not found after move. Error. * fix: bugs in staff_profile js — ✓ complete * fix: move image ot after job title, not just name * feat: use ut seal if no staff photo * style: captialization in css comments * style: consistency in css comments * feat: model access via admin interface * style: nx format:write * chore: remove excess property on admin class * docs: in css comment warn about coupled html & css * fix: donot require photo field * feat: to load staff profile css+js on manual page * refactor: c-staff-profile → s-staff-profile * docs: remove inaccurate comment * docs: remove excess comment * docs: asset comment cleanup * fix: remove experience from forms and output * chore: move 'education" to bottom of form * feat: less margin beneath `<h3>` * docs: label blocks of css with different goals * docs: group css that actuall has the same goal * docs: title case css grouping comment * Add plugin for rapid generation of staff pages - more design tweaks (#300) * Add plugin for rapid generation of staff pages - manually squash migrations (#304) * docs: add staff_profile/README to log known issues * chore: nx format:write --------- Co-authored-by: Jake Rosenberg <jrosenberg@MacBook-Pro.lan> Co-authored-by: Wesley B <62723358+wesleyboar@users.noreply.github.com> Co-authored-by: Wesley Bomar <wbomar@tacc.utexas.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Changes after Design Review № 2.
Related
Changes
missing space between elementsuser error caused by developer mistake (see [1])
reduce margin under headings (except in content-block)fixed in Add plugin for rapid generation of staff pages #253 at 71b3319
Testing
UI
Before
before.mov
After
after.mov