fix: tup-549 improve mfa unpair modal #288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
changed the title
wesleyboar
added a commit
that referenced
this pull request
Aug 3, 2023
Proejct styles first introduced in: #288 When mature, they should become Core Styles.
wesleyboar
commented
Aug 3, 2023
There was a problem hiding this comment.
This is a "Project Style". These are newly documented in #289.
wesleyboar
changed the title
jarosenb
added a commit
that referenced
this pull request
Sep 5, 2023
* docs: distinguish global styles and project styles Proejct styles first introduced in: #288 When mature, they should become Core Styles. * docs: readme ToC typo --------- Co-authored-by: Jake Rosenberg <jrosenberg@tacc.utexas.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview / Changes
A.2. The unpair UI should be: (1) wider modal, (2) two steps laid out like MFA pairing, (3) help message at bottom middle like in MFA pairing. (4) "If you lost your phone…" should say "Alternatively, unpair via email."
Status
Related
Testing / UI
In Progress
Notes
The link as a label is not bold. That is a Core-Styles bug, fixed in TACC/Core-Styles#216.