Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tup-549 improve mfa unpair modal - use pages, not modal #293

Closed
wants to merge 19 commits into from
Closed

fix: tup-549 improve mfa unpair modal - use pages, not modal #293

wants to merge 19 commits into from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Aug 10, 2023 •
edited
Loading

Overview

Move MFA Unpairing out of a modal (and use #288 redesign).

Status

Important
Closed in favor of #306 which is final result of #293 off of #288.

Warning
Successful pair and unpair do not navigate user to success page. User can refresh but will still be on pair or unpair page. User can navigate back to Manage Account and begin process that matches their token state. My MfaWrapper logic is flawed.

Related

Changes

  • added two new routes unpair/totp and unpair/sms
  • moved MFA unpairing out of ManageAccoutnMfa into MfaUnpairingView
  • added heading above loading spinner for Manage Account MFA block
  • added style to center align MFA message text

Testing

  1. …

UI

…

@wesleyboar wesleyboar changed the title feat: de-modal mfa unpair fix: tup-542 (8) improve mfa unpair modal - use pages, not modal Aug 10, 2023
@wesleyboar wesleyboar mentioned this pull request Aug 10, 2023
Closed
@wesleyboar wesleyboar changed the title fix: tup-542 (8) improve mfa unpair modal - use pages, not modal fix: tup-549 improve mfa unpair modal - use pages, not modal Aug 10, 2023
@wesleyboar
Copy link
Member Author

Closed in favor of #306 which is final result of #293 off of #288.

@wesleyboar wesleyboar closed this Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar