Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lintspaces on Linux showing warnings instead of errors #12169

Closed
zhaojj2209 opened this issue Mar 6, 2023 · 1 comment · Fixed by #13152 · May be fixed by itstrueitstrueitsrealitsreal/teammates#7
Closed

Lintspaces on Linux showing warnings instead of errors #12169

zhaojj2209 opened this issue Mar 6, 2023 · 1 comment · Fixed by #13152 · May be fixed by itstrueitstrueitsrealitsreal/teammates#7

Comments

@zhaojj2209
Copy link
Contributor

Currently, on GitHub actions, there are cases where linting will pass for Ubuntu but fail on Windows because trailing spaces are identified as warnings instead of errors.

Ubuntu:
Screenshot 2023-03-06 at 12 39 34

Windows:
Screenshot 2023-03-06 at 12 39 14
@sumitshinde-84
Copy link
Contributor

sumitshinde-84 commented Mar 12, 2023 •
edited
Loading

@zhaojj2209 Can I work on this issue?

This was referenced Jul 25, 2024
Open
Merged
domoberzin pushed a commit that referenced this issue Jul 31, 2024
@itstrueitstrueitsrealitsreal @mingyuanc
[#12169] Update teammates-eslint.yml to mark trailing whitespaces a…
cdee5f2 
…s errors on Ubuntu (#13152)

* Modify eslint ruleset

* Fix checkstyle

* Fix checkstyle

* Edit ruleset

* Fix checkstyle

* Fix checkstyle

* Fix checkstyle

---------

Co-authored-by: Ching Ming Yuan <cmingyuan123@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zhaojj2209 @sumitshinde-84