Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12169] Update teammates-eslint.yml to mark trailing whitespaces as errors on Ubuntu #13152

Merged
merged 9 commits into from
Jul 31, 2024

Conversation

itstrueitstrueitsrealitsreal
Copy link
Contributor

Fixes #12169

Outline of Solution

I updated teammates-eslint.yml to be stricter, indicating trailing whitespaces in .html files as errors instead of warnings, which were reported to be able to pass using Ubuntu in comparison to Windows linting workflows.

I also made the decision to ignore blank lines, as they were required in the templating of the emails sent out to users, and changing them would cause component tests to fail.

@domoberzin domoberzin self-requested a review July 28, 2024 04:17
Copy link
Contributor

@mingyuanc mingyuanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mingyuanc mingyuanc added the s.FinalReview The PR is ready for final review label Jul 30, 2024
Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@domoberzin domoberzin merged commit cdee5f2 into TEAMMATES:master Jul 31, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.FinalReview The PR is ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lintspaces on Linux showing warnings instead of errors
3 participants