-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12048] Migrate SubmitFeedbackResponseAction #12720
[#12048] Migrate SubmitFeedbackResponseAction #12720
Conversation
9c7f46e
to
3a20b49
Compare
Remove unnecessary comments Remove unnecessary comments Save progress Add draft Add draft
3a20b49
to
c4228c7
Compare
…grate-submit-feedbackresponse-action
…grate-submit-feedbackresponse-action
…grate-submit-feedbackresponse-action
…ommentsCascade Revert unnecessary changes, add tests Fix linting and tests Add changes Revert changes Revert changes Add tests Add lint changes
76c403d
to
50d3f61
Compare
…grate-submit-feedbackresponse-action
469403e
to
563e033
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for the work on this (extensive testing is definitely needed, thanks in advance for working on the test cases in the next PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well! Thank you for the hard work!
Part of #12048
This PR is part 2 of 3 for SubmitFeedbackResponseAction , and is related to #12732 and #12760. Tests will be migrated in #12760.