Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12048] Migrate SubmitFeedbackResponseAction #12720

Conversation

FergusMok
Copy link
Contributor

@FergusMok FergusMok commented Feb 2, 2024

Part of #12048

This PR is part 2 of 3 for SubmitFeedbackResponseAction , and is related to #12732 and #12760. Tests will be migrated in #12760.

@cedricongjh cedricongjh added this to the V9.0.0-beta.0 milestone Feb 2, 2024
@jayasting98 jayasting98 added the s.Ongoing The PR is being worked on by the author(s) label Feb 3, 2024
@FergusMok FergusMok force-pushed the 12048-migrate-submit-feedbackresponse-action branch 2 times, most recently from 9c7f46e to 3a20b49 Compare February 5, 2024 06:52
Remove unnecessary comments

Remove unnecessary comments

Save progress

Add draft

Add draft
@FergusMok FergusMok force-pushed the 12048-migrate-submit-feedbackresponse-action branch from 3a20b49 to c4228c7 Compare February 5, 2024 06:54
@FergusMok FergusMok force-pushed the 12048-migrate-submit-feedbackresponse-action branch from 76c403d to 50d3f61 Compare February 18, 2024 03:49
@FergusMok FergusMok force-pushed the 12048-migrate-submit-feedbackresponse-action branch from 469403e to 563e033 Compare February 19, 2024 13:38
@FergusMok FergusMok marked this pull request as ready for review February 19, 2024 13:43
@FergusMok FergusMok added s.ToReview The PR is waiting for review(s) and removed s.Ongoing The PR is being worked on by the author(s) labels Feb 19, 2024
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the work on this (extensive testing is definitely needed, thanks in advance for working on the test cases in the next PR)

Copy link
Contributor

@ziqing26 ziqing26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well! Thank you for the hard work!

@ziqing26 ziqing26 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Feb 19, 2024
@cedricongjh cedricongjh merged commit 70f7801 into TEAMMATES:v9-migration Feb 19, 2024
6 of 7 checks passed
@weiquu weiquu added the c.Task Other non-user-facing works, e.g. refactoring, adding tests label Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants