Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12048] Migrate SubmitFeedbackResponseAction tests #13033

Merged
merged 12 commits into from
May 2, 2024

Conversation

FergusMok
Copy link
Contributor

Part of #12048

3rd out of the 3 PRs to migrate SubmitFeedbackResponseAction (#12732 and #12720)

Copy link

Hi @FergusMok, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@FergusMok FergusMok force-pushed the fix-submit-feedback-resposne branch from f0321ef to def7f0a Compare April 16, 2024 16:18
@FergusMok FergusMok force-pushed the fix-submit-feedback-resposne branch from def7f0a to 86e6329 Compare April 16, 2024 16:19
@FergusMok FergusMok self-assigned this Apr 16, 2024
@FergusMok FergusMok added the s.ToReview The PR is waiting for review(s) label Apr 16, 2024
Copy link
Contributor

@ziqing26 ziqing26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FergusMok FergusMok merged commit 34248a0 into TEAMMATES:master May 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.ToReview The PR is waiting for review(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants