-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12048] Migrate SubmitFeedbackResponseAction tests #13033
Merged
FergusMok
merged 12 commits into
TEAMMATES:master
from
FergusMok:fix-submit-feedback-resposne
May 2, 2024
Merged
[#12048] Migrate SubmitFeedbackResponseAction tests #13033
FergusMok
merged 12 commits into
TEAMMATES:master
from
FergusMok:fix-submit-feedback-resposne
May 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @FergusMok, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
FergusMok
force-pushed
the
fix-submit-feedback-resposne
branch
from
April 16, 2024 16:18
f0321ef
to
def7f0a
Compare
FergusMok
force-pushed
the
fix-submit-feedback-resposne
branch
from
April 16, 2024 16:19
def7f0a
to
86e6329
Compare
ziqing26
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
3rd out of the 3 PRs to migrate SubmitFeedbackResponseAction (#12732 and #12720)