Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#13147] Didn't Account for the Timezone in Session Edit Form component tests #13148

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

Respirayson
Copy link
Contributor

Fixes #13147

Outline of Solution
Added .tz() to account for the timezones when comparing the datetimes.

Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@domoberzin domoberzin merged commit 9181467 into TEAMMATES:master Jul 26, 2024
11 checks passed
itstrueitstrueitsrealitsreal pushed a commit to itstrueitstrueitsrealitsreal/teammates that referenced this pull request Jul 27, 2024
…m component tests (TEAMMATES#13148)

Update pr.yml

Update pr.yml

Update pr.yml
mingyuanc pushed a commit that referenced this pull request Jul 30, 2024
* Add check for closed issue

* Update message

* Rephrase message

* Add logging

* Test

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Add check for closed issue

Update message

Rephrase message

Add logging

Test

Update pr.yml

* [#13147] Didn't Account for the Timezone in Session Edit Form component tests (#13148)

Update pr.yml

Update pr.yml

Update pr.yml

* Update pr.yml

* Update workflow

---------

Co-authored-by: Rayson Yeap <88478542+Respirayson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Didn't Account for the Timezone in Session Edit Form component tests
2 participants