Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11383] Add detection of PRs linking to closed issues #13154

Merged
merged 19 commits into from
Jul 30, 2024

Conversation

itstrueitstrueitsrealitsreal
Copy link
Contributor

@itstrueitstrueitsrealitsreal itstrueitstrueitsrealitsreal commented Jul 27, 2024

Part of #11383

Outline of Solution
Modified pr.yml to check for the status of the issue that newly created pull requests are solving using the pr.data.state.description attribute from GitHub's REST API for issues, allowing users to be notified that the issue they are trying to work on is already closed, as per Automation Hero in the wiki. Tested on my personal fork.

Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, but I think we may need to make some changes

.github/workflows/pr.yml Outdated Show resolved Hide resolved
.github/workflows/pr.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@domoberzin domoberzin added the s.FinalReview The PR is ready for final review label Jul 28, 2024
Copy link
Contributor

@mingyuanc mingyuanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, interesting solution!

@mingyuanc mingyuanc merged commit ea30a05 into TEAMMATES:master Jul 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.FinalReview The PR is ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants