-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] "Clear Index Queue" TypeError Site is null #4095
Comments
sal-lochbaum
added a commit
to salient-doremus/ext-solr
that referenced
this issue
Jul 19, 2024
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this issue
Jul 29, 2024
Fixes index queue clearance in multi site environment. Fixes: TYPO3-Solr#4095 Co-authored-by: Markus Friedrich <markus.friedrich@dkd.de>
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this issue
Jul 30, 2024
Fixes index queue clearance in multi site environment. Fixes: TYPO3-Solr#4095 Co-authored-by: Markus Friedrich <markus.friedrich@dkd.de>
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this issue
Jul 30, 2024
Fixes index queue clearance in multi site environment. Fixes: TYPO3-Solr#4095 Co-authored-by: Markus Friedrich <markus.friedrich@dkd.de>
dkd-kaehm
pushed a commit
that referenced
this issue
Jul 30, 2024
Fixes index queue clearance in multi site environment. Fixes: #4095 Co-authored-by: Markus Friedrich <markus.friedrich@dkd.de>
Fixed in #4120 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When I click the "Clear Index Queue" button in the Index Queue backend module I get an error response from Typo3:
(1/1) TypeError
ApacheSolrForTypo3\Solr\IndexQueue\Queue::deleteItemsBySite(): Argument #1 ($site) must be of type ApacheSolrForTypo3\Solr\Domain\Site\Site, null given, called in /var/www/html/vendor/apache-solr-for-typo3/solr/Classes/Controller/Backend/Search/AbstractModuleController.php on line 231
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clean index queue
Used versions (please complete the following information):
This probably also applies to master/13 as the relevant code is the same.
Additional context
There is a fallback in AbstractModuleController->initializeAction called "autoSelectFirstSiteAndRootPageWhenOnlyOneSiteIsAvailable" which probably "hides" this bug if you only have one site.
As far as I could debug it:
<f:form action="clearIndexQueue" additionalParams="{id: '{pageUID}'}">
I narrowed it down to the initializeAction beeing called twice:
IMO the manual call should be deleted
ext-solr/Classes/Controller/Backend/Search/IndexQueueModuleController.php
Line 68 in 4c13753
The text was updated successfully, but these errors were encountered: