-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] ManagedSynonyms language determination #1
Conversation
The ManagedSynonymsFilterFactory was moved from indexAnalyzer to queryAnalyzer, therefore we must look there in the schema in order to determine the language. Resolves: #65676 Change-Id: I63e99c240f0d019dc411d7fe56204b273e1d715c
This changes make the extension usable under PHP 5.6 Resolves: #65490 Change-Id: I7b226c99dbc707950215b8ab5004fe96d0bb685b
@@ -33,7 +33,7 @@ | |||
} | |||
], | |||
"require": { | |||
"php": ">5.3.0,~5.5.0" | |||
"php": ">5.3.0,~5.6.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a reason for this change, you're not using any 5.6 specific features, are you? The other thing is to try to keep this in line with the TYPO3 LTS requirements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought about it: This is fine with me, we actually should raise the minimum PHP version to at least 5.4, maybe even 5.6. Definitely for EXT:solr 3.1.
We shouldn't support EOL PHP versions, even if CMS might say otherwise.
http://php.net/supported-versions.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ubuntu 12.04 LTS (Precise Pangolin) has PHP 5.3.10 and has support untill 2017.
Ubuntu 14.04 LTS (Trusty Tahr) has PHP 5.5.12 and has support until 2019.
See: https://launchpad.net/ubuntu/+source/php5
I would suggest to stick our Ubuntu reference installation with 5.3 to 5.5 for the moment.
LGTM |
[BUGFIX] ManagedSynonyms language determination
If using PHP 8.1, the following exception is thrown ``` PHP Runtime Deprecation Notice: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in ``` Cast the value to a string to avoid the exception
…must be of type int, string given
…must be of type int, string given Fixes: TYPO3-Solr#3267
… type int, string given Fixes: #3267
Third release candidate of 11.5.0 for TYPO3 11 LTS Huge improvements: * TYPO3 11 LTS compatibility * Improved data update handling Known issues: * [BUG] IMAGES in indexer configurations handled in BE mode since TYPO3 10.4.12 TYPO3-Solr#2828 Open tasks: * [TASK] Finalize lastSearches Integration test cases TYPO3-Solr#3160 Improvements and fixes since RC 2: * [DOCS:BP:11.5] add missing doc for ...logging.indexing.pageIndexed * [TASK:BP:11.5] Adjust typo3/coding-standards settings * [BUGFIX:BP:11.5] Empty suggest query triggers a PHP error TYPO3-Solr#3302 * [BUGFIX] Respect indexing configuration for new and updated subpages TYPO3-Solr#3276 * [BUGFIX] Class properties must not be accessed before initialization TYPO3-Solr#3288 * [BUGFIX:11.5] Frequent Searches plugin does not work TYPO3-Solr#3166 * [BUGFIX] Ensure array value is set when accessing TYPO3-Solr#3269 * [BUGFIX] Fix PSR-4 Namesppaces and Paths TYPO3-Solr#3285 * [BUGFIX] Undefined array key in ..Domain\Site\Site:L130 TYPO3-Solr#3232 * [BUGFIX] Silence DebugWriter for PageIndexerRequest TYPO3-Solr#3030 * [BUGFIX] AbstractSolrTask::setRootPageId(): Argument TYPO3-Solr#1 () must be of type int, string given TYPO3-Solr#3267 * [TASK] Update GarbageCollector.php TYPO3-Solr#3249 * [TASK] Sync with EXT:solrfluidgrouping for TYPO3 11.5 * [TASK] Sync with new TYPO3 coding standards * [BUGFIX] Avoid yoda-style conditions in PHP * [BUGFIX] change detection of free mode records TYPO3-Solr#3264 * [BUGFIX] Fix return type error for option facet TYPO3-Solr#3260 * [FEATURE] Make pageRangeFirst and pageRangeLast accessible in fluid TYPO3-Solr#3254 Note for non-composer instances: This release candidate is not available in TYPO3 TER, if you want to try this release, please download and install this release manually from: https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.5.0-rc-3 --- How to Get Involved There are many ways to get involved with Apache Solr for TYPO3: * Submit bug reports and feature requests on GitHub * Ask or help or answer questions in our Slack channel * Provide patches through pull requests or review and comment on existing pull requests * Go to www.typo3-solr.com or call dkd to sponsor the ongoing development of Apache Solr for TYPO3 Support us by becoming an EB partner: https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/ or call: +49 (0)69 - 2475218 0
Third release candidate of 11.5.0 for TYPO3 11 LTS Huge improvements: * TYPO3 11 LTS compatibility * Improved data update handling Known issues: * [BUG] IMAGES in indexer configurations handled in BE mode since TYPO3 10.4.12 TYPO3-Solr#2828 Open tasks: * [TASK] Finalize lastSearches Integration test cases TYPO3-Solr#3160 Improvements and fixes since RC 2: * [FEATURE] Add custom field processors TYPO3-Solr#1811 * [TASK] Adapt column arrangement within sites config TYPO3-Solr#3295 * [DOCS:BP:11.5] add missing doc for ...logging.indexing.pageIndexed * [TASK:BP:11.5] Adjust typo3/coding-standards settings * [BUGFIX:BP:11.5] Empty suggest query triggers a PHP error TYPO3-Solr#3302 * [BUGFIX] Respect indexing configuration for new and updated subpages TYPO3-Solr#3276 * [BUGFIX] Class properties must not be accessed before initialization TYPO3-Solr#3288 * [BUGFIX:11.5] Frequent Searches plugin does not work TYPO3-Solr#3166 * [BUGFIX] Ensure array value is set when accessing TYPO3-Solr#3269 * [BUGFIX] Fix PSR-4 Namesppaces and Paths TYPO3-Solr#3285 * [BUGFIX] Undefined array key in ..Domain\Site\Site:L130 TYPO3-Solr#3232 * [BUGFIX] Silence DebugWriter for PageIndexerRequest TYPO3-Solr#3030 * [BUGFIX] AbstractSolrTask::setRootPageId(): Argument TYPO3-Solr#1 () must be of type int, string given TYPO3-Solr#3267 * [TASK] Update GarbageCollector.php TYPO3-Solr#3249 * [TASK] Sync with EXT:solrfluidgrouping for TYPO3 11.5 * [TASK] Sync with new TYPO3 coding standards * [BUGFIX] Avoid yoda-style conditions in PHP * [BUGFIX] change detection of free mode records TYPO3-Solr#3264 * [BUGFIX] Fix return type error for option facet TYPO3-Solr#3260 * [FEATURE] Make pageRangeFirst and pageRangeLast accessible in fluid TYPO3-Solr#3254 Note for non-composer instances: This release candidate is not available in TYPO3 TER, if you want to try this release, please download and install this release manually from: https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.5.0-rc-3 --- How to Get Involved There are many ways to get involved with Apache Solr for TYPO3: * Submit bug reports and feature requests on GitHub * Ask or help or answer questions in our Slack channel * Provide patches through pull requests or review and comment on existing pull requests * Go to www.typo3-solr.com or call dkd to sponsor the ongoing development of Apache Solr for TYPO3 Support us by becoming an EB partner: https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/ or call: +49 (0)69 - 2475218 0
Third release candidate of 11.5.0 for TYPO3 11 LTS Huge improvements: * TYPO3 11 LTS compatibility * Improved data update handling Known issues: * [BUG] IMAGES in indexer configurations handled in BE mode since TYPO3 10.4.12 #2828 Open tasks: * [TASK] Finalize lastSearches Integration test cases #3160 Improvements and fixes since RC 2: * [FEATURE] Add custom field processors #1811 * [TASK] Adapt column arrangement within sites config #3295 * [DOCS:BP:11.5] add missing doc for ...logging.indexing.pageIndexed * [TASK:BP:11.5] Adjust typo3/coding-standards settings * [BUGFIX:BP:11.5] Empty suggest query triggers a PHP error #3302 * [BUGFIX] Respect indexing configuration for new and updated subpages #3276 * [BUGFIX] Class properties must not be accessed before initialization #3288 * [BUGFIX:11.5] Frequent Searches plugin does not work #3166 * [BUGFIX] Ensure array value is set when accessing #3269 * [BUGFIX] Fix PSR-4 Namesppaces and Paths #3285 * [BUGFIX] Undefined array key in ..Domain\Site\Site:L130 #3232 * [BUGFIX] Silence DebugWriter for PageIndexerRequest #3030 * [BUGFIX] AbstractSolrTask::setRootPageId(): Argument #1 () must be of type int, string given #3267 * [TASK] Update GarbageCollector.php #3249 * [TASK] Sync with EXT:solrfluidgrouping for TYPO3 11.5 * [TASK] Sync with new TYPO3 coding standards * [BUGFIX] Avoid yoda-style conditions in PHP * [BUGFIX] change detection of free mode records #3264 * [BUGFIX] Fix return type error for option facet #3260 * [FEATURE] Make pageRangeFirst and pageRangeLast accessible in fluid #3254 Note for non-composer instances: This release candidate is not available in TYPO3 TER, if you want to try this release, please download and install this release manually from: https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.5.0-rc-3 --- How to Get Involved There are many ways to get involved with Apache Solr for TYPO3: * Submit bug reports and feature requests on GitHub * Ask or help or answer questions in our Slack channel * Provide patches through pull requests or review and comment on existing pull requests * Go to www.typo3-solr.com or call dkd to sponsor the ongoing development of Apache Solr for TYPO3 Support us by becoming an EB partner: https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/ or call: +49 (0)69 - 2475218 0
This is a maintaine release for TYPO3 10.4, containing: - [BUGFIX] Prepend wrong fe language on empty cache (TYPO3-Solr#3375) - [TASK] Use TYPO3 IpAnonymizationUtility (TYPO3-Solr#3262) - [BUGFIX:BP:11.2] Shortcircuit work in SolrRoutingMiddleware (TYPO3-Solr#3202) - [TASK] Fix scrutinizer on release-11.2.x - [BUGFIX:BP:11.2] Do not handle page updates on new page with uid 0 (TYPO3-Solr#3338) - [TASK] Remove not used strptime() adaption for windows. - [BUGFIX] Respect indexing configuration for new and updated subpages (TYPO3-Solr#3276) - [BUGFIX] Ensure keywords string does not exceed database field length (TYPO3-Solr#3321) - [TASK:BP:11.2] Adapt column arrangement within sites config (TYPO3-Solr#3295) - [DOCS:BP:11.2] add missing doc for ..pageIndexed (#) - [BUGFIX] Fix PSR-4 Namespaces and Paths (TYPO3-Solr#3285) - [BUGFIX] Silence DebugWriter for PageIndexerRequest (TYPO3-Solr#3030) - [BUGFIX] AbstractSolrTask::setRootPageId(): Argument TYPO3-Solr#1 () must be of type int, string given (TYPO3-Solr#3267) - [BUGFIX:11.2] Update GarbageCollector.php (TYPO3-Solr#3249) - [DOCS] Align with new TYPO3 documentation standards (TYPO3-Solr#3242) - [DOCS] Align README.md with other extensions (TYPO3-Solr#3218) - [BUGFIX] Missing dot in configuration in numberOfResultsPerGroup method (TYPO3-Solr#3098 - [TASK] Added info about using page content in fields - [TASK] Added info about the virtual field __solr_contents - [BUGFIX:BP:11.2] Fix write connection (TYPO3-Solr#2916) Please read the release notes: https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.1.3 --- How to Get Involved There are many ways to get involved with Apache Solr for TYPO3: Submit bug reports and feature requests on GitHub Ask or help or answer questions in our Slack channel Provide patches through Pull Request or review and comment on existing Pull Requests Go to www.typo3-solr.com or call dkd to sponsor the ongoing development of Apache Solr for TYPO3 Support us by becoming an EB partner: https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/ or call: +49 (0)69 - 2475218 0
This is a maintenance release for TYPO3 10.4, containing: - [BUGFIX] Prepend wrong fe language on empty cache (TYPO3-Solr#3375) - [TASK] Use TYPO3 IpAnonymizationUtility (TYPO3-Solr#3262) - [BUGFIX:BP:11.2] Shortcircuit work in SolrRoutingMiddleware (TYPO3-Solr#3202) - [TASK] Fix scrutinizer on release-11.2.x - [BUGFIX:BP:11.2] Do not handle page updates on new page with uid 0 (TYPO3-Solr#3338) - [TASK] Remove not used strptime() adaption for windows. - [BUGFIX] Respect indexing configuration for new and updated subpages (TYPO3-Solr#3276) - [BUGFIX] Ensure keywords string does not exceed database field length (TYPO3-Solr#3321) - [TASK:BP:11.2] Adapt column arrangement within sites config (TYPO3-Solr#3295) - [DOCS:BP:11.2] add missing doc for ..pageIndexed (#) - [BUGFIX] Fix PSR-4 Namespaces and Paths (TYPO3-Solr#3285) - [BUGFIX] Silence DebugWriter for PageIndexerRequest (TYPO3-Solr#3030) - [BUGFIX] AbstractSolrTask::setRootPageId(): Argument TYPO3-Solr#1 () must be of type int, string given (TYPO3-Solr#3267) - [BUGFIX:11.2] Update GarbageCollector.php (TYPO3-Solr#3249) - [DOCS] Align with new TYPO3 documentation standards (TYPO3-Solr#3242) - [DOCS] Align README.md with other extensions (TYPO3-Solr#3218) - [BUGFIX] Missing dot in configuration in numberOfResultsPerGroup method (TYPO3-Solr#3098 - [TASK] Added info about using page content in fields - [TASK] Added info about the virtual field __solr_contents - [BUGFIX:BP:11.2] Fix write connection (TYPO3-Solr#2916) Please read the release notes: https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.2.1 --- How to Get Involved There are many ways to get involved with Apache Solr for TYPO3: Submit bug reports and feature requests on GitHub Ask or help or answer questions in our Slack channel Provide patches through Pull Request or review and comment on existing Pull Requests Go to www.typo3-solr.com or call dkd to sponsor the ongoing development of Apache Solr for TYPO3 Support us by becoming an EB partner: https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/ or call: +49 (0)69 - 2475218 0
This is a maintenance release for TYPO3 10.4, containing: - [BUGFIX] Prepend wrong fe language on empty cache (TYPO3-Solr#3375) - [TASK] Use TYPO3 IpAnonymizationUtility (TYPO3-Solr#3262) - [BUGFIX:BP:11.2] Shortcircuit work in SolrRoutingMiddleware (TYPO3-Solr#3202) - [TASK] Fix scrutinizer on release-11.2.x - [BUGFIX:BP:11.2] Do not handle page updates on new page with uid 0 (TYPO3-Solr#3338) - [TASK] Remove not used strptime() adaption for windows. - [BUGFIX] Respect indexing configuration for new and updated subpages (TYPO3-Solr#3276) - [BUGFIX] Ensure keywords string does not exceed database field length (TYPO3-Solr#3321) - [TASK:BP:11.2] Adapt column arrangement within sites config (TYPO3-Solr#3295) - [DOCS:BP:11.2] add missing doc for ..pageIndexed - [BUGFIX] Fix PSR-4 Namespaces and Paths (TYPO3-Solr#3285) - [BUGFIX] Silence DebugWriter for PageIndexerRequest (TYPO3-Solr#3030) - [BUGFIX] AbstractSolrTask::setRootPageId(): Argument TYPO3-Solr#1 must be of type int, string given (TYPO3-Solr#3267) - [BUGFIX:11.2] Update GarbageCollector.php (TYPO3-Solr#3249) - [DOCS] Align with new TYPO3 documentation standards (TYPO3-Solr#3242) - [DOCS] Align README.md with other extensions (TYPO3-Solr#3218) - [BUGFIX] Missing dot in configuration in numberOfResultsPerGroup method (TYPO3-Solr#3098 - [TASK] Added info about using page content in fields - [TASK] Added info about the virtual field __solr_contents - [BUGFIX:BP:11.2] Fix write connection (TYPO3-Solr#2916) Please read the release notes: https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.2.1 --- How to Get Involved There are many ways to get involved with Apache Solr for TYPO3: Submit bug reports and feature requests on GitHub Ask or help or answer questions in our Slack channel Provide patches through Pull Request or review and comment on existing Pull Requests Go to www.typo3-solr.com or call dkd to sponsor the ongoing development of Apache Solr for TYPO3 Support us by becoming an EB partner: https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/ or call: +49 (0)69 - 2475218 0
This is a maintenance release for TYPO3 10.4, containing: - [BUGFIX] Prepend wrong fe language on empty cache (#3375) - [TASK] Use TYPO3 IpAnonymizationUtility (#3262) - [BUGFIX:BP:11.2] Shortcircuit work in SolrRoutingMiddleware (#3202) - [TASK] Fix scrutinizer on release-11.2.x - [BUGFIX:BP:11.2] Do not handle page updates on new page with uid 0 (#3338) - [TASK] Remove not used strptime() adaption for windows. - [BUGFIX] Respect indexing configuration for new and updated subpages (#3276) - [BUGFIX] Ensure keywords string does not exceed database field length (#3321) - [TASK:BP:11.2] Adapt column arrangement within sites config (#3295) - [DOCS:BP:11.2] add missing doc for ..pageIndexed - [BUGFIX] Fix PSR-4 Namespaces and Paths (#3285) - [BUGFIX] Silence DebugWriter for PageIndexerRequest (#3030) - [BUGFIX] AbstractSolrTask::setRootPageId(): Argument #1 must be of type int, string given (#3267) - [BUGFIX:11.2] Update GarbageCollector.php (#3249) - [DOCS] Align with new TYPO3 documentation standards (#3242) - [DOCS] Align README.md with other extensions (#3218) - [BUGFIX] Missing dot in configuration in numberOfResultsPerGroup method (#3098 - [TASK] Added info about using page content in fields - [TASK] Added info about the virtual field __solr_contents - [BUGFIX:BP:11.2] Fix write connection (#2916) Please read the release notes: https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.2.1 --- How to Get Involved There are many ways to get involved with Apache Solr for TYPO3: Submit bug reports and feature requests on GitHub Ask or help or answer questions in our Slack channel Provide patches through Pull Request or review and comment on existing Pull Requests Go to www.typo3-solr.com or call dkd to sponsor the ongoing development of Apache Solr for TYPO3 Support us by becoming an EB partner: https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/ or call: +49 (0)69 - 2475218 0
…lper Problem: Calling the `s:searchForm` ViewHelper with the `pageType` or `suggestPageType` argument with a value from a typoscript setting will lead to a TypeError ```html <s:searchForm pageType="{settings.pageType}" suggestPageType="{settings.suggestPageType}"> ``` `TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder::setTargetPageType(): Argument #1 ($targetPageType) must be of type int, string given, called in /var/www/html/private/typo3conf/ext/solr/Classes/ViewHelpers/SearchFormViewHelper.php` Solution: Cast both arguments to int Fixes: #3927 Ports: #3728
Fixes issue after PHPStan 1.11 upgrade: ``` Parameter #1 $boost of class ApacheSolrForTypo3\Solr\Domain\Search\Score\Score constructor expects float, string given. ```
…and language [0] -> make default Language configurable
…and language [0] -> make default Language configurable
…and language [0] -> make default Language configurable
…and language [0] -> make default Language configurable
The ManagedSynonymsFilterFactory was moved from indexAnalyzer to
queryAnalyzer, therefore we must look there in the schema in order
to determine the language.
Resolves: #65676
Change-Id: I63e99c240f0d019dc411d7fe56204b273e1d715c